Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dtls: cleanup some code #20602

Closed
wants to merge 3 commits into from
Closed

dtls: cleanup some code #20602

wants to merge 3 commits into from

Conversation

FdaSilvaYY
Copy link
Contributor

  • factorize BIO_CTRL_DGRAM_SET_NEXT_TIMEOUT calls.
  • simplify a return type
  • style nits
Checklist
  • documentation is added or updated
  • tests are added or updated

@FdaSilvaYY
dtls: cleanup some code
707e759 
- factorize BIO_CTRL_DGRAM_SET_NEXT_TIMEOUT calls.
- simplify a return type
- style nits
@FdaSilvaYY
Copy link
Contributor Author

Spinoff from #14344

@FdaSilvaYY FdaSilvaYY mentioned this pull request Mar 25, 2023
Open
2 tasks
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: refactor The issue/pr requests/implements refactoring tests: exempted The PR is exempt from requirements for testing labels Mar 27, 2023
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Mar 27, 2023
tmshort
tmshort reviewed Apr 14, 2023
View reviewed changes
ssl/d1_lib.c Outdated Show resolved Hide resolved
tmshort
tmshort reviewed Apr 14, 2023
View reviewed changes
ssl/d1_lib.c Outdated Show resolved Hide resolved
tmshort
tmshort reviewed Apr 14, 2023
View reviewed changes
ssl/d1_lib.c Outdated Show resolved Hide resolved
@FdaSilvaYY
fixup! dtls: cleanup some code - factorize BIO_CTRL_DGRAM_SET_NEXT_TI…
54976ee 
…MEOUT calls. - simplify a return type - style nits
@FdaSilvaYY
Copy link
Contributor Author

@tmshort : fixup pushed, thanks for the review.

@FdaSilvaYY
fixup! fixup! dtls: cleanup some code - factorize BIO_CTRL_DGRAM_SET_…
84e65d3 
…NEXT_TIMEOUT calls. - simplify a return type - style nits
@FdaSilvaYY FdaSilvaYY requested a review from tmshort April 15, 2023 08:53
@tmshort tmshort added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 19, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 20, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m t8m removed the approval: ready to merge The 24 hour grace period has passed, ready to merge label Apr 21, 2023
@t8m t8m added the approval: done This pull request has the required number of approvals label Apr 21, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Apr 22, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Apr 24, 2023

Merged to master branch. Thank you for your contribution.

@t8m t8m closed this Apr 24, 2023
openssl-machine pushed a commit that referenced this pull request Apr 24, 2023
@FdaSilvaYY @t8m
dtls: code cleanup and refactorization
24a3225 
- factorize BIO_CTRL_DGRAM_SET_NEXT_TIMEOUT calls.
- simplify a return type
- style nits

Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #20602)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@tmshort tmshort tmshort approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: exempted The PR is exempt from requirements for testing triaged: refactor The issue/pr requests/implements refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@FdaSilvaYY @openssl-machine @t8m @tmshort