Add openssl/fuzz-corpora as submodule #20683
Conversation
To be replaced with a git submodule.
t8m
added
branch: master
Otherwise the fuzz/corpora won't be present.
t8m
force-pushed
the
fuzz-corpora-submodule
branch
from
549f00f
to
59268bb
Compare
levitte
removed
the
approval: otc review pending
t-j-h
added
approval: done
|
Fixup was needed - we do not want submodules for check update and check docs CI runs. |
|
Reconfirmed. |
|
Additional question - do we want to move the fuzz/corpora data to submodule also in 3.1 and 3.0 branches? |
|
I would leave stable branches alone for this sort of stuff - but I won't put a hold if others think differently. |
Yeah, unless we would like to add more testing data to older branches we can keep them as is. |
|
I would actually do this same thing on the release branches too, simply to avoid all the duplication. Stuff in new subdirectories will be ignored by them, as they won't have the corresponding fuzz testing driver. But, I don't see a need to do this nownownow. |
|
Just an observation, looking at some other builds this seems to add a few minutes of build time to some of the builds (e.g basic_gcc) (i.e. we are now always retrieving 10 submodules) |
|
Any chance of limiting the submodules to just the fuzzer? |
Yeah, there is no such option. I assume we would have to call git explicitly. |
|
Assuming the last change works 😁 |
t8m
force-pushed
the
fuzz-corpora-submodule
branch
from
e03855d
to
eae1688
Compare
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
kroeckx
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to master branch. Thank you for the reviews. |
To be replaced with a git submodule. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #20683)
Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #20683)
Otherwise the fuzz/corpora won't be present. Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #20683)
Instead of carrying the fuzz corpora data in the source code repository we move it into a submodule pulled from https://github.com/openssl/fuzz-corpora