Fix UEFI support on win32 #20714
Closed
Fix UEFI support on win32 #20714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t8m
approved these changes
Apr 11, 2023
t8m
added
branch: master
github-actions
bot
added
the
severity: fips change
hlandau
approved these changes
Apr 11, 2023
hlandau
added
approval: done
|
24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually. |
|
Failing CI tests are the existing issue with CIFuzz, and unrelated. Updating labels to |
tom-cosgrove-arm
added
approval: ready to merge
|
Merged to master. Thank you. |
openssl-machine
pushed a commit
that referenced
this pull request
Apr 13, 2023
Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #20714)
This comment was marked as spam.
This comment was marked as spam.
MrE-Fog
pushed a commit
to MrE-Fog/opensslz
that referenced
this pull request
Apr 15, 2023
Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl/openssl#20714)
|
Isn't this a bug fix for backport to 3.1 and 3.0?? @hlandau only mentions merge to master and this only has the "branch:master" label on it. |
This is not applicable to 3.1 or 3.0 branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes fix building OpenSSL v3.x on win32 hosts targeting UEFI.