Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links in crypto manpage #20741

Closed
wants to merge 2 commits into from
Closed

Fix broken links in crypto manpage #20741

wants to merge 2 commits into from

Conversation

Lipovlan
Copy link
Contributor

CLA: trivial

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Apr 15, 2023
@Lipovlan
Copy link
Contributor Author

I thought I was fixing broken links due to them looking out of place, but the corresponding pages do not exists. Closing this issue.

@Lipovlan Lipovlan closed this Apr 15, 2023
@Lipovlan
Change link destination
e720d54 
The corresponding manpage is called `OSSL_PROVIDER-FIPS` and not `OSSL_PROVIDER-fips`, kind of breaking the convention.

CLA: trivial
@Lipovlan Lipovlan reopened this Apr 15, 2023
@openssl-machine openssl-machine removed hold: cla required The contributor needs to submit a license agreement labels Apr 15, 2023
@Lipovlan
Copy link
Contributor Author

I found out that the link name should have been different. I fixed that as well and reopened the pull request.

paulidale
paulidale approved these changes Apr 16, 2023
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay with trivial.

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: documentation The issue/pr deals with documentation (errors) cla: trivial One of the commits is marked as 'CLA: trivial' tests: exempted The PR is exempt from requirements for testing branch: 3.1 Merge to openssl-3.1 labels Apr 16, 2023
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Okay with cla: trivial

@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Apr 17, 2023
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

openssl-machine pushed a commit that referenced this pull request Apr 18, 2023
@Lipovlan @paulidale
Fix broken links in crypto manpage
d79b610 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #20741)
@paulidale
Copy link
Contributor

Merged, thanks for the fixes.

openssl-machine pushed a commit that referenced this pull request Apr 18, 2023
@Lipovlan @paulidale
Fix broken links in crypto manpage
58c4a2e 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #20741)

(cherry picked from commit d79b610)
@paulidale paulidale closed this Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 3.1 Merge to openssl-3.1 cla: trivial One of the commits is marked as 'CLA: trivial' tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Lipovlan @openssl-machine @paulidale @t8m @tom-cosgrove-arm