Add minimal handling of NEW_CONNECTION_ID frames #20892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t8m
added
branch: master
hlandau
requested changes
May 5, 2023
|
Also, can you confirm if you've tested this code against a server which issues a Retry? I'd be interested to know. |
Do you have any hints on how to write the test? I can think of only somehow modifying the test server to issue NEW_CONNECTION_ID frame. |
As far as I know the Cloudflare Quiche issues a retry. But I'll verify. |
paulidale
reviewed
May 7, 2023
paulidale
approved these changes
May 9, 2023
t8m
added
tests: present
hlandau
approved these changes
May 11, 2023
|
Looks good, needs second reapproval. @paulidale |
|
@hlandau I've added also a negative testcase, please reconfirm |
hlandau
approved these changes
May 11, 2023
paulidale
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Sorry but this PR is currently incompatible with master branch. Needs rebasing and fixing for test/quic_newcid_test.c because of missing parameters. |
We actively use only the latest DCID received. And retire only DCIDs requested by the peer to be retired. Also changed the active_conn_id_limit to 2 as the minimum value allowed.
seq_id must be >= retire_prior_to. Add negative testcase.
|
Rebased to resolve merge conflicts please reconfirm @paulidale @hlandau |
t8m
added
approval: review pending
paulidale
approved these changes
May 16, 2023
paulidale
removed
the
approval: otc review pending
hlandau
approved these changes
May 16, 2023
hlandau
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to master. Thank you. |
openssl-machine
pushed a commit
that referenced
this pull request
May 17, 2023
Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #20892)
openssl-machine
pushed a commit
that referenced
this pull request
May 17, 2023
We actively use only the latest DCID received. And retire only DCIDs requested by the peer to be retired. Also changed the active_conn_id_limit to 2 as the minimum value allowed. Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #20892)
openssl-machine
pushed a commit
that referenced
this pull request
May 17, 2023
seq_id must be >= retire_prior_to. Add negative testcase. Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #20892)
openssl-machine
pushed a commit
that referenced
this pull request
May 17, 2023
Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #20892)
openssl-machine
pushed a commit
that referenced
this pull request
May 17, 2023
Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #20892)
openssl-machine
pushed a commit
that referenced
this pull request
May 17, 2023
Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #20892)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actively use only the latest DCID received. And retire only
DCIDs requested by the peer to be retired.
Also changed the active_conn_id_limit to 2 as the minimum value allowed.
Adding test for this will be non-trivial but we will need it so setting
tests: deferred.I assume we can do something with the fault injector.