Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APPS http_server.c: allow clients to connect with IPv6 #21033

Closed
wants to merge 1 commit into from
Closed

APPS http_server.c: allow clients to connect with IPv6 #21033

wants to merge 1 commit into from

Conversation

DDvO
Copy link
Contributor

@DDvO DDvO commented May 23, 2023

So far, the test server used for OCSP and CMP only supports IPv4 connections.
This adds support for IPv6, inspired by #15992 (comment).

Extend doc and tests accordingly.
On this occasion, fix minor glitches in openssl-ocsp.pod.in.

Checklist
  • documentation is added or updated
  • tests are added or updated

@DDvO DDvO added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: feature The issue/pr requests/adds a feature triaged: documentation The issue/pr deals with documentation (errors) tests: present The PR has suitable tests present labels May 23, 2023
@DDvO DDvO added this to the 3.2.0 milestone May 23, 2023
@DDvO
Copy link
Contributor Author

DDvO commented May 24, 2023

One of the CI job runs had failed for unrelated reasons:

unable to access 'https://github.com/openssl/openssl/': The requested URL returned error: 429

Just found that GitHub offers the nice feature to selectively re-run failed jobs,
so no need to kick the whole PR in such cases.

@t8m t8m removed the triaged: documentation The issue/pr deals with documentation (errors) label May 26, 2023
@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/otc but the last update was 61 days ago

@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Jul 31, 2023
@DDvO
Copy link
Contributor Author

DDvO commented Aug 13, 2023

@openssl/committers this PR has been waiting for quite some time for the 2nd review, which should be rather straightforward.

beldmit
beldmit approved these changes Aug 13, 2023
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Aug 13, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Aug 14, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@DDvO
Copy link
Contributor Author

DDvO commented Aug 15, 2023

Merged - thanks @t8m and @beldmit for your approvals.

openssl-machine pushed a commit that referenced this pull request Aug 15, 2023
@DDvO
http_server.c: allow clients to connect with IPv6
830b6a1 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #21033)
@DDvO DDvO closed this Aug 15, 2023
@t8m t8m mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@beldmit beldmit beldmit approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: present The PR has suitable tests present triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DDvO @openssl-machine @t8m @beldmit