Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl pkcs12 -export: Ignore the fetch error when a legacy algorithm is found #21035

Closed
wants to merge 1 commit into from
Closed

openssl pkcs12 -export: Ignore the fetch error when a legacy algorithm is found #21035

wants to merge 1 commit into from

Conversation

ypenkin
Copy link
Contributor

@ypenkin ypenkin commented May 23, 2023 •
edited 

openssl pkcs12 -engine gost -export -inkey seckey.pem -in cert.pem -out user.pfx -keypbe gost89 -certpbe gost89 -macalg md_gost12_256
Engine "gost" set.
Enter Export Password:
Verifying - Enter Export Password:
00040D4CB27F0000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:../../../../openssl/crypto/evp/evp_fetch.c:373:Global default library context, Algorithm (md_gost12_512 : 107), Properties (<null>)
00040D4CB27F0000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:../../../../openssl/crypto/evp/evp_fetch.c:373:Global default library context, Algorithm (md_gost12_512 : 107), Properties (<null>)
00040D4CB27F0000:error:0308010C:digital envelope routines:inner_evp_generic_fetch:unsupported:../../../../openssl/crypto/evp/evp_fetch.c:373:Global default library context, Algorithm (GOST R 34.11-2012 with 256 bit hash : 101), Properties (<null>)
0

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label May 23, 2023
@ypenkin ypenkin force-pushed the fix_fetch_error_pkcs12_export branch from 6ccea61 to 245233e Compare May 23, 2023 22:00
@beldmit
Copy link
Member

beldmit commented May 24, 2023

This change is beyond trivial and you will have to submit the CLA to make it accepted.
LGTM otherwise

@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label May 24, 2023
@ypenkin
Copy link
Contributor Author

ypenkin commented May 24, 2023

I have submitted a signed ICLA today

@beldmit beldmit closed this May 24, 2023
@beldmit beldmit reopened this May 24, 2023
@github-actions github-actions bot removed the severity: fips change The pull request changes FIPS provider sources label May 24, 2023
@beldmit beldmit closed this May 24, 2023
@beldmit beldmit reopened this May 24, 2023
@beldmit
Copy link
Member

beldmit commented May 24, 2023

Who can check the CLA status? close/open the issue doesn't show updates

beldmit
beldmit approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added branch: master Merge to master branch approval: review pending This pull request needs review by a committer labels May 24, 2023
@beldmit beldmit closed this May 25, 2023
@beldmit beldmit reopened this May 25, 2023
@beldmit
Copy link
Member

beldmit commented May 25, 2023

@mattcaswell could you please check the CLA status?

@ypenkin ypenkin closed this May 26, 2023
@ypenkin ypenkin reopened this May 26, 2023
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label May 26, 2023
@t8m t8m added approval: done This pull request has the required number of approvals triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing and removed approval: review pending This pull request needs review by a committer labels May 26, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels May 27, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Jun 1, 2023
@ypenkin @beldmit
Ignore the fetch error when a legacy algorithm is found
cb1f87f 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #21035)
openssl-machine pushed a commit that referenced this pull request Jun 1, 2023
@ypenkin @beldmit
Ignore the fetch error when a legacy algorithm is found
745a716 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #21035)

(cherry picked from commit cb1f87f)
openssl-machine pushed a commit that referenced this pull request Jun 1, 2023
@ypenkin @beldmit
Ignore the fetch error when a legacy algorithm is found
dc4ccc7 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from #21035)

(cherry picked from commit cb1f87f)
@beldmit
Copy link
Member

beldmit commented Jun 1, 2023

Merged to 3.0, 3.1, an master.
Many thanks for your contribution!

@beldmit beldmit closed this Jun 1, 2023
MrE-Fog pushed a commit to MrE-Fog/opensslxxixx that referenced this pull request Jun 4, 2023
@ypenkin @MrE-Fog
Ignore the fetch error when a legacy algorithm is found
8d3ab64 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from openssl/openssl#21035)

(cherry picked from commit cb1f87f59d0b290eca9207ec4ef36d8073e6feec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@beldmit beldmit beldmit approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ypenkin @beldmit @openssl-machine @t8m