Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUIC: CID conformance #21078

Closed
wants to merge 2 commits into from
Closed

QUIC: CID conformance #21078

wants to merge 2 commits into from

Conversation

paulidale
Copy link
Contributor

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: feature The issue/pr requests/adds a feature tests: exempted The PR is exempt from requirements for testing labels May 30, 2023
@paulidale paulidale added this to the 3.2.0 milestone May 30, 2023
@paulidale paulidale self-assigned this May 30, 2023
t8m
t8m requested changes May 30, 2023
View reviewed changes
ssl/quic/quic_channel.c Outdated Show resolved Hide resolved
ssl/quic/quic_channel.c Show resolved Hide resolved
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label May 30, 2023
@paulidale
Copy link
Contributor Author

Ping @openssl/committers for second review please.

FdaSilvaYY
FdaSilvaYY reviewed May 31, 2023
View reviewed changes
Copy link
Contributor

@FdaSilvaYY FdaSilvaYY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ssl/quic/quic_channel.c Show resolved Hide resolved
ssl/quic/quic_channel.c Show resolved Hide resolved
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 31, 2023
@paulidale
Copy link
Contributor Author

Merged, thanks for the comments

@paulidale paulidale closed this Jun 1, 2023
@paulidale paulidale deleted the quic-cid-conformance branch June 1, 2023 07:24
openssl-machine pushed a commit that referenced this pull request Jun 1, 2023
@paulidale
QUIC: CID conformance
985429f 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #21078)
MrE-Fog pushed a commit to MrE-Fog/opensslxxixx that referenced this pull request Jun 4, 2023
@paulidale @MrE-Fog
QUIC: CID conformance
320068c 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl/openssl#21078)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@FdaSilvaYY FdaSilvaYY FdaSilvaYY left review comments

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees

@paulidale paulidale

Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch tests: exempted The PR is exempt from requirements for testing triaged: feature The issue/pr requests/adds a feature
Projects
Project Board
Status: Done
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@paulidale @t8m @mattcaswell @FdaSilvaYY