Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tags: fix `make tags' target for out of tree builds #21079

Closed
wants to merge 1 commit into from
Closed

tags: fix `make tags' target for out of tree builds #21079

wants to merge 1 commit into from

Conversation

paulidale
Copy link
Contributor

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing labels May 30, 2023
@paulidale paulidale self-assigned this May 30, 2023
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label May 30, 2023
@paulidale
Copy link
Contributor Author

Ping @openssl/committers for second review please.

beldmit
beldmit approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels May 31, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jun 1, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor Author

Merged, thanks for the reviews.

@paulidale paulidale closed this Jun 1, 2023
@paulidale paulidale deleted the ctags-out-of-tree branch June 1, 2023 06:13
openssl-machine pushed a commit that referenced this pull request Jun 1, 2023
@paulidale
tags: fix make tags target for out of tree builds
2a6a044 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from #21079)
MrE-Fog pushed a commit to MrE-Fog/opensslxxixx that referenced this pull request Jun 4, 2023
@paulidale @MrE-Fog
tags: fix make tags target for out of tree builds
cfa3f0a 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from openssl/openssl#21079)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@tmshort tmshort tmshort approved these changes

@beldmit beldmit beldmit approved these changes

Assignees

@paulidale paulidale

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@paulidale @openssl-machine @t8m @tmshort @beldmit