Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: note that our ChaCha20 isn't standard compliant. #21098

Closed
wants to merge 2 commits into from
Closed

doc: note that our ChaCha20 isn't standard compliant. #21098

wants to merge 2 commits into from

Conversation

paulidale
Copy link
Contributor

Fixes #21095

  • documentation is added or updated
  • tests are added or updated

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 labels May 31, 2023
@paulidale paulidale self-assigned this May 31, 2023
t8m
t8m reviewed Jun 1, 2023
View reviewed changes
doc/man3/EVP_chacha20.pod Outdated Show resolved Hide resolved
@levitte
Copy link
Member

levitte commented Jun 1, 2023

Kicking the CIs

@levitte levitte closed this Jun 1, 2023
@levitte levitte reopened this Jun 1, 2023
@t8m t8m added tests: exempted The PR is exempt from requirements for testing and removed approval: otc review pending This pull request needs review by an OTC member labels Jun 2, 2023
@paulidale
Copy link
Contributor Author

Ping @openssl/committers for 2nd review.

@slontis slontis added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jun 5, 2023
@tom-cosgrove-arm tom-cosgrove-arm changed the title doc: note that out ChaCha20 isn't standard compliant. doc: note that our ChaCha20 isn't standard compliant. Jun 5, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jun 6, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor Author

Merged, thanks for the reviews.

@paulidale paulidale closed this Jun 6, 2023
@paulidale paulidale deleted the chacha-ctr branch June 6, 2023 01:03
openssl-machine pushed a commit that referenced this pull request Jun 6, 2023
@paulidale
doc: note that out ChaCha20 isn't standard compliant.
c69756e 
Fixes #21095

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #21098)
openssl-machine pushed a commit that referenced this pull request Jun 6, 2023
@paulidale
doc: note that out ChaCha20 isn't standard compliant.
b207e0e 
Fixes #21095

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #21098)

(cherry picked from commit c69756e)
openssl-machine pushed a commit that referenced this pull request Jun 6, 2023
@paulidale
doc: note that out ChaCha20 isn't standard compliant.
1e8f555 
Fixes #21095

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from #21098)

(cherry picked from commit c69756e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@slontis slontis slontis approved these changes

Assignees

@paulidale paulidale

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EVP_chacha20 does not match RFC 7539 or documentation in nonce/counter split
5 participants
@paulidale @levitte @openssl-machine @t8m @slontis