Fix EVP_PKEY_asn1_copy

[HangzeGao]

Add the copy of the omitted ASN1 public key method

Fixes #21115

[t8m]

This is borderline on what we accept with CLA: trivial

@paulidale ?

[paulidale]

I'm fine with trivial. There isn't another way to do this.

[tmshort]

I don't see sig_print being copied?

There isn't another way to do this.

One could play with structure offsets and memcpy(); or by saving the dst real data (5 items), then memcpy(dst, src, sizeof(*src)), then restoring the dst data. An optimization would be to have the function and non-function data in different structs that could be copied separately.

Unless the compiler is smart enough to know the out-of-order listing (e.g. old_priv_decode) is contiguous memory, but since sig_print() is also missing, it can't.

[slontis]

In master we are doing:

 int  x = dst->x;
 ....
 *dst = *src
 
 dst->x = x;
 ....

Doing the change listed here is probably not trivial..

[tmshort]

Doing the change listed here is probably not trivial..

For what I suggest, agreed.

[openssl-machine]

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

[tom-cosgrove-arm]

@HangzeGao Can you update with @bernd-edlinger's suggestion, please?

@openssl/otc So if this is not acceptable under CLA: trivial, have we asked for @HangzeGao to sign and submit an ICLA?

[mattcaswell]

https://github.com/orgs/openssl/teams/otc So if this is not acceptable under CLA: trivial, have we asked for @HangzeGao to sign and submit an ICLA?

We have reviewers saying it isn't trivial, so therefore a CLA is required. @HangzeGao - please can you submit one?

[beldmit]

LGTM

I'd consider it trivial, speaking frankly.

[HangzeGao]

https://github.com/orgs/openssl/teams/otc So if this is not acceptable under CLA: trivial, have we asked for @HangzeGao to sign and submit an ICLA?

We have reviewers saying it isn't trivial, so therefore a CLA is required. @HangzeGao - please can you submit one?

I have submitted the ICLA. I also closed and reopened it. But the CLA check still failed.

[mattcaswell]

But the CLA check still failed.

It's failing because the email address in the author field of the commit does not match the email address provided in the CLA.

[openssl-machine]

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

[bernd-edlinger]

@HangzeGao please change the Author in your commit to your correct e-mail address like this:

git commit --amend --author "test <test@test.com>"
git push -f

[t8m]

Merged to 1.1.1 branch. Thank you for your contribution.