Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMP doc: backport improvements on MAC-based protection and critical server authentication #21138

Closed
wants to merge 3 commits into from
Closed

CMP doc: backport improvements on MAC-based protection and critical server authentication #21138

wants to merge 3 commits into from

Conversation

DDvO
Copy link
Contributor

@DDvO DDvO commented Jun 6, 2023

This backports to 3.0 and 3.1 those parts of the doc improvements contained in #21129 that apply also to these stable branches:

  • CMP app and API doc: add note on critical server auth on receiving trust anchor certs
  • CMP doc: various text improvements, mostly on PBM vs. MAC-based protection
Checklist
  • documentation is added or updated
  • tests are added or updated

@DDvO DDvO added approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 labels Jun 6, 2023
@DDvO DDvO changed the title Cmp doc mac trust backport CMP doc: backport improvements on MAC-based protection and critical server authentication Jun 6, 2023
@DDvO DDvO mentioned this pull request Jun 6, 2023
Closed
2 tasks
@DDvO DDvO force-pushed the CMP_doc_MAC_trust-backport branch from a58c916 to 3ecf4e9 Compare June 6, 2023 17:59
@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/otc but the last update was 30 days ago

@paulidale paulidale removed the approval: otc review pending This pull request needs review by an OTC member label Jul 7, 2023
@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

@DDvO
Copy link
Contributor Author

DDvO commented Aug 13, 2023

@openssl/committers this PR has been waiting for quite some time for the 2nd review, which should be very straightforward

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

@DDvO
Copy link
Contributor Author

DDvO commented Sep 14, 2023

@openssl/committers please let's get this closed soon - the 2nd review should easy,
in particular since the PR for master has already been fully approved and merged.

mattcaswell
mattcaswell approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with or without the comment above being addressed.

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 15, 2023
@DDvO
Copy link
Contributor Author

DDvO commented Sep 15, 2023 •
edited

Approved with or without the comment above being addressed.

Thanks @mattcaswell for your approval -
as explained above, I believe it's better to keep "with PBM".

@DDvO DDvO mentioned this pull request Sep 15, 2023
Closed
2 tasks
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@paulidale paulidale added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Sep 17, 2023
openssl-machine pushed a commit that referenced this pull request Sep 18, 2023
@DDvO
CMP doc: various small corrections, mostly on PBM vs. MAC-based prote…
4a10739 
…ction

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #21138)
openssl-machine pushed a commit that referenced this pull request Sep 18, 2023
@DDvO
CMP app and API doc: add note on critical server auth on receiving tr…
5e721ec 
…ust anchor certs

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #21138)
@DDvO
Copy link
Contributor Author

DDvO commented Sep 18, 2023

Merged to 3.0 and 3.1 - thanks  @paulidale and @mattcaswell

@DDvO DDvO closed this Sep 18, 2023
openssl-machine pushed a commit that referenced this pull request Sep 18, 2023
@DDvO
CMP doc: various small corrections, mostly on PBM vs. MAC-based prote…
61549d4 
…ction

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #21138)

(cherry picked from commit 4a10739)
openssl-machine pushed a commit that referenced this pull request Sep 18, 2023
@DDvO
CMP app and API doc: add note on critical server auth on receiving tr…
488e054 
…ust anchor certs

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #21138)

(cherry picked from commit 5e721ec)
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Sep 23, 2023
@DDvO
CMP doc: various small corrections, mostly on PBM vs. MAC-based prote…
3c71514 
…ction

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from openssl/openssl#21138)

Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Sep 23, 2023
@DDvO
CMP app and API doc: add note on critical server auth on receiving tr…
840928c 
…ust anchor certs

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from openssl/openssl#21138)

Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Sep 23, 2023
@DDvO
CMP doc: various small corrections, mostly on PBM vs. MAC-based prote…
e176712 
…ction

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from openssl/openssl#21138)

(cherry picked from commit 4a1073981fcff530d3f810b536514eb45d5d0bae)
Signed-off-by: fly2x <fly2x@hitls.org>
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Sep 23, 2023
@DDvO
CMP app and API doc: add note on critical server auth on receiving tr…
8504f83 
…ust anchor certs

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from openssl/openssl#21138)

(cherry picked from commit 5e721ecee5a8c9c27e392fb3770d221709bde1a7)
Signed-off-by: fly2x <fly2x@hitls.org>
xl32 pushed a commit to xl32/openssl that referenced this pull request Sep 29, 2023
@DDvO @xl32
CMP doc: various small corrections, mostly on PBM vs. MAC-based prote…
86e0c05 
…ction

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from openssl#21138)
xl32 pushed a commit to xl32/openssl that referenced this pull request Sep 29, 2023
@DDvO @xl32
CMP app and API doc: add note on critical server auth on receiving tr…
b9ea353 
…ust anchor certs

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from openssl#21138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DDvO @openssl-machine @mattcaswell @paulidale