Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast the argument to unsigned char when calling isspace() #21151

Closed
wants to merge 1 commit into from
Closed

Cast the argument to unsigned char when calling isspace() #21151

wants to merge 1 commit into from

Conversation

baentsch
Copy link
Contributor

@baentsch baentsch commented Jun 8, 2023

Fixes further build issues for "strict" checks in cygwin (see #21006 (comment)).

@baentsch baentsch mentioned this pull request Jun 8, 2023
Closed
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing labels Jun 8, 2023
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Jun 8, 2023
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jun 8, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jun 9, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Jun 9, 2023
@baentsch @t8m
Cast the argument to unsigned char when calling isspace()
8a2e74d 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21151)
@t8m
Copy link
Member

t8m commented Jun 9, 2023

Merged to master, 3.1 and 3.0 branches. Thank you for the contribution.

@t8m t8m closed this Jun 9, 2023
openssl-machine pushed a commit that referenced this pull request Jun 9, 2023
@baentsch @t8m
Cast the argument to unsigned char when calling isspace()
79331b8 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21151)

(cherry picked from commit 8a2e74d)
openssl-machine pushed a commit that referenced this pull request Jun 9, 2023
@baentsch @t8m
Cast the argument to unsigned char when calling isspace()
fefeecf 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21151)

(cherry picked from commit 8a2e74d)
MrE-Fog pushed a commit to MrE-Fog/opensslsc that referenced this pull request Jun 10, 2023
@baentsch @MrE-Fog
Cast the argument to unsigned char when calling isspace()
56ee733 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl/openssl#21151)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@baentsch @openssl-machine @t8m @mattcaswell