Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partially revert #18070 (Add support for Windows CA certificate store) #21190

Closed
wants to merge 2 commits into from
Closed

Partially revert #18070 (Add support for Windows CA certificate store) #21190

wants to merge 2 commits into from

Conversation

hlandau
Copy link
Member

@hlandau hlandau commented Jun 13, 2023

As discussed at OTC. Blocker for 3.2. I kept and tweaked the documentation and the store itself.

@hlandau hlandau added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing labels Jun 13, 2023
@hlandau hlandau self-assigned this Jun 13, 2023
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Jun 13, 2023
@mattcaswell mattcaswell removed the approval: otc review pending This pull request needs review by an OTC member label Jun 13, 2023
t8m
t8m requested changes Jun 13, 2023
View reviewed changes
doc/man3/X509_get_default_cert_file.pod Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
doc/man3/X509_get_default_cert_file.pod Outdated Show resolved Hide resolved
@hlandau
Copy link
Member Author

hlandau commented Jun 14, 2023

Updated.

@t8m
Copy link
Member

t8m commented Jun 14, 2023

@mattcaswell please reconfirm

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jun 14, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jun 15, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor

Merged.

@paulidale paulidale closed this Jun 15, 2023
openssl-machine pushed a commit that referenced this pull request Jun 15, 2023
@hlandau @paulidale
Partially revert #18070 (Add support for Windows CA certificate store)
dfdbc11 
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21190)
@hlandau hlandau mentioned this pull request Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

Assignees

@hlandau hlandau

Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch severity: fips change The pull request changes FIPS provider sources tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hlandau @t8m @openssl-machine @paulidale @levitte @mattcaswell