Reformat M_check_autoarg to match our coding style #2121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levitte
added
branch: 1.0.2
richsalz
suggested changes
Dec 20, 2016
| } \ | ||
| } | ||
| if (ctx->pmeth->flags & EVP_PKEY_FLAG_AUTOARGLEN) { \ | ||
| size_t pksize = (size_t)EVP_PKEY_size(ctx->pkey); \ |
| if (pksize == 0) { \ | ||
| EVPerr(err, EVP_R_INVALID_KEY); /*ckerr_ignore*/ \ | ||
| return 0; \ | ||
| } else if (!arg) { \ |
There was a problem hiding this comment.
remove the else after return. since this is all inside an if() statement, it's still one statement.
and in the else-if below.
|
I think I've fixed what you asked, @richsalz . Please re-review. |
richsalz
approved these changes
Dec 20, 2016
levitte
added a commit
that referenced
this pull request
Dec 20, 2016
Reviewed-by: Rich Salz <rsalz@openssl.org> (Merged from #2121)
|
Merged. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of change