Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to disable apps building #21212

Closed
wants to merge 4 commits into from
Closed

allow to disable apps building #21212

wants to merge 4 commits into from

Conversation

vladak
Copy link
Contributor

@vladak vladak commented Jun 15, 2023

This trivial change allows to disable apps building. It's handy for minimization.

The option was already there and adhered to by apps/build.info, however Configure did not allow to use it directly, only via cascading.

@mattcaswell
Copy link
Member

Any new option should be documented in INSTALL.md

@vladak
Copy link
Contributor Author

vladak commented Jun 15, 2023

Any new option should be documented in INSTALL.md

Fixed.

@t8m
Copy link
Member

t8m commented Jun 15, 2023

We would need a run-checker target for that no-apps build option and I assume you'll find that many tests will fail without apps so you'll need to fix those failures, which will be a quite tedious patch to do.

@t8m t8m added branch: master Merge to master branch triaged: feature The issue/pr requests/adds a feature hold: needs tests The PR needs tests to be added to it labels Jun 15, 2023
@mattcaswell
Copy link
Member

I assume you'll find that many tests will fail without apps so you'll need to fix those failures, which will be a quite tedious patch to do.

Nope. "no-apps" cascades to "no-tests" so the tests simply don't run at all.

@t8m
Copy link
Member

t8m commented Jun 15, 2023

Nope. "no-apps" cascades to "no-tests" so the tests simply don't run at all.

Ah, right. That makes the option pretty limiting.

@mattcaswell
Copy link
Member

We would need a run-checker target for that no-apps build option

@vladak - as per @t8m's feedback please could you add an entry for this in .github/workflows/run-checker-daily.yml

@vladak
Copy link
Contributor Author

vladak commented Jun 16, 2023

We would need a run-checker target for that no-apps build option

@vladak - as per @t8m's feedback please could you add an entry for this in .github/workflows/run-checker-daily.yml

Sure, added.

@mattcaswell mattcaswell added tests: present The PR has suitable tests present and removed hold: needs tests The PR needs tests to be added to it labels Jun 16, 2023
@mattcaswell mattcaswell added the approval: review pending This pull request needs review by a committer label Jun 16, 2023
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jun 16, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jun 17, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Jun 23, 2023

Squashed and merged to master branch. Thank you for your contribution.

@t8m t8m closed this Jun 23, 2023
openssl-machine pushed a commit that referenced this pull request Jun 23, 2023
@vladak @t8m
Allow to disable apps building with no-apps
ff88545 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: present The PR has suitable tests present triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vladak @mattcaswell @t8m @openssl-machine @tom-cosgrove-arm