Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl speed -multi -evp prints wrong algorithm name #21216

Closed
wants to merge 1 commit into from

Conversation

jo-so
Copy link
Contributor

@jo-so jo-so commented Jun 15, 2023

When running openssl speed -evp md5 the result shows md5 as algorithm name. But when adding the option -multi 2 it gives evp as algorithm name.

Checklist
  • documentation is added or updated
  • tests are added or updated

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Jun 15, 2023
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Jun 15, 2023
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one code style nit.

apps/speed.c Outdated Show resolved Hide resolved
@paulidale
Copy link
Contributor

I think this is beyond the scope of CLA: trivial.
Could you submit a CLA please?

@paulidale paulidale added hold: cla required The contributor needs to submit a license agreement branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug cla: trivial One of the commits is marked as 'CLA: trivial' branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing labels Jun 15, 2023
@tom-cosgrove-arm tom-cosgrove-arm removed the cla: trivial One of the commits is marked as 'CLA: trivial' label Jun 16, 2023
@tom-cosgrove-arm
Copy link
Contributor

Removed the cla: trivial label, since it's not!

@t8m t8m added the cla: trivial One of the commits is marked as 'CLA: trivial' label Jun 16, 2023
@t8m
Copy link
Member

t8m commented Jun 16, 2023

@tom-cosgrove-arm the label indicates the commit has the CLA: trivial designation. Not that it is acceptable under CLA: trivial.

@tom-cosgrove-arm
Copy link
Contributor

@t8m ah, okay, thanks for clarifying - sorry for the misunderstanding

@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Jun 25, 2023
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Jun 26, 2023
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Jun 26, 2023
@jo-so jo-so requested a review from paulidale June 26, 2023 19:10
When running `openssl speed -evp md5` the result shows `md5` as algorithm
name. But when adding the option `-multi 2` it gives `evp` as algorithm
name.

Signed-off-by: Jörg Sommer <joerg@jo-so.de>
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jun 27, 2023
@tom-cosgrove-arm
Copy link
Contributor

@t8m Are you happy with the changes?

@t8m t8m removed the cla: trivial One of the commits is marked as 'CLA: trivial' label Jun 27, 2023
@github-actions github-actions bot removed the severity: fips change The pull request changes FIPS provider sources label Jun 27, 2023
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@t8m
Copy link
Member

t8m commented Jun 28, 2023

Merged to master, 3.1, and 3.0 branches. Thank you for your contribution.

@t8m t8m closed this Jun 28, 2023
openssl-machine pushed a commit that referenced this pull request Jun 28, 2023
When running `openssl speed -evp md5` the result shows `md5` as algorithm
name. But when adding the option `-multi 2` it gives `evp` as algorithm
name.

Signed-off-by: Jörg Sommer <joerg@jo-so.de>

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21216)
openssl-machine pushed a commit that referenced this pull request Jun 28, 2023
When running `openssl speed -evp md5` the result shows `md5` as algorithm
name. But when adding the option `-multi 2` it gives `evp` as algorithm
name.

Signed-off-by: Jörg Sommer <joerg@jo-so.de>

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21216)

(cherry picked from commit 33c0934)
openssl-machine pushed a commit that referenced this pull request Jun 28, 2023
When running `openssl speed -evp md5` the result shows `md5` as algorithm
name. But when adding the option `-multi 2` it gives `evp` as algorithm
name.

Signed-off-by: Jörg Sommer <joerg@jo-so.de>

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21216)

(cherry picked from commit 33c0934)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants