Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add no-docs Configure option #21240

Closed
wants to merge 2 commits into from
Closed

add no-docs Configure option #21240

wants to merge 2 commits into from

Conversation

vladak
Copy link
Contributor

@vladak vladak commented Jun 19, 2023

This change introduces the no-docs Configure option. This is handy for minimization.

@mattcaswell
Copy link
Member

Can't this mostly be done simply by not installing the docs? i.e. "make install_sw" instead of "make install"

@vladak
Copy link
Contributor Author

vladak commented Jun 19, 2023

Can't this mostly be done simply by not installing the docs? i.e. "make install_sw" instead of "make install"

Personally I prefer this is done in the configure phase, because in our environment OpenSSL is built multiple times with different options and this allows to concentrate all the changes to the configure phase and not override the install phase.

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: feature The issue/pr requests/adds a feature hold: needs tests The PR needs tests to be added to it labels Jun 23, 2023
@t8m
Copy link
Member

t8m commented Jun 23, 2023

Please add runchecker-daily CI run for this option.

@vladak
Copy link
Contributor Author

vladak commented Jun 24, 2023

Please add runchecker-daily CI run for this option.

Added.

@t8m t8m added tests: present The PR has suitable tests present and removed hold: needs tests The PR needs tests to be added to it labels Jun 26, 2023
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Jun 26, 2023
@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jun 26, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jun 27, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor

Merged, thanks for the contribution.

@paulidale paulidale closed this Jun 27, 2023
openssl-machine pushed a commit that referenced this pull request Jun 27, 2023
@vladak @paulidale
add no-docs option
956b4c7 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21240)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: present The PR has suitable tests present triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vladak @mattcaswell @t8m @openssl-machine @paulidale