Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new typos found by codespell #21322

Closed
wants to merge 3 commits into from
Closed

Fix new typos found by codespell #21322

wants to merge 3 commits into from

Conversation

DimitriPapadopoulos
Copy link
Contributor

It might be useful to automate this and run codespell or another spell checking tool. However:

  • There will always be false positives, especially in OpenSSL, because of its large code base and choice of variable names (ciphe or ciphr instead of cipher for example), Someone needs to maintain a list of false positives, and perhaps run the spell checking tool without it from time to time, to catch false negatives.
  • The dictionaries are updated from time to time, resulting in new true or false positives that may interfere with commits that are ortogonal to spell checking.
Checklist
  • documentation is added or updated
  • tests are added or updated

@tom-cosgrove-arm tom-cosgrove-arm added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: documentation The issue/pr deals with documentation (errors) cla: trivial One of the commits is marked as 'CLA: trivial' tests: exempted The PR is exempt from requirements for testing labels Jun 29, 2023
tom-cosgrove-arm
tom-cosgrove-arm approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this is on the border of what is acceptable under trivial - it's not just one or two typos found, but a systematic review of the codebase (admittedly with an automated tool)

What do others think?

@tom-cosgrove-arm tom-cosgrove-arm removed the approval: review pending This pull request needs review by a committer label Jun 29, 2023
hlandau
hlandau reviewed Jun 29, 2023
View reviewed changes
Copy link
Member

@hlandau hlandau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with trivial.

paulidale
paulidale approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with trivial for this.

@paulidale paulidale removed the approval: otc review pending This pull request needs review by an OTC member label Jun 29, 2023
mattcaswell
mattcaswell approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@mattcaswell mattcaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok with trivial

@mattcaswell mattcaswell added the approval: done This pull request has the required number of approvals label Jun 29, 2023
@mattcaswell
Copy link
Member

To me this is on the border of what is acceptable under trivial - it's not just one or two typos found, but a systematic review of the codebase (admittedly with an automated tool)

Yes, on the borderline. But I think it is ok.

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@tom-cosgrove-arm tom-cosgrove-arm added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jun 30, 2023
@paulidale
Copy link
Contributor

Merged, thanks for the contribution.

@paulidale paulidale closed this Jun 30, 2023
openssl-machine pushed a commit that referenced this pull request Jun 30, 2023
@DimitriPapadopoulos @paulidale
Fix new typos found by codespell in man pages
e8104bb 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21322)
openssl-machine pushed a commit that referenced this pull request Jun 30, 2023
@DimitriPapadopoulos @paulidale
Fix new typos found by codespell in documentation
6a2b826 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21322)
openssl-machine pushed a commit that referenced this pull request Jun 30, 2023
@DimitriPapadopoulos @paulidale
Fix new typo found by codespell in demo
4409e15 
Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21322)
@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch June 30, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlandau hlandau hlandau left review comments

@mattcaswell mattcaswell mattcaswell approved these changes

@paulidale paulidale paulidale approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@DimitriPapadopoulos @mattcaswell @openssl-machine @paulidale @hlandau @tom-cosgrove-arm