Add limited support for WebAssembly WASI target #21344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openssl-machine
added
the
hold: cla required
loganek
force-pushed
the
loganek/limited-wasi
branch
from
247d573
to
4e909f3
Compare
openssl-machine
removed
the
hold: cla required
paulidale
requested changes
Jul 2, 2023
paulidale
added
branch: master
github-actions
bot
added
the
severity: fips change
CLA: trivial
loganek
force-pushed
the
loganek/limited-wasi
branch
from
4e909f3
to
32ae0bf
Compare
paulidale
approved these changes
Jul 3, 2023
paulidale
added
the
approval: review pending
github-actions
bot
removed
the
severity: fips change
t-j-h
approved these changes
Jul 5, 2023
t-j-h
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged, thanks for the contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 6, 2023
CLA: trivial Reviewed-by: Tim Hudson <tjh@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #21344)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of experiments regarding compiling CURL into WebAssembly/WASI and running on WAMR (socket API is not standardized yet) I had to make a few fixes to make an HTTPS call to a server. The change probably doesn't cover all the usecases, but it's a good start I guess.
If the community in general agrees with the approach, I'll update the CI scripts so we can make sure the WASM/WASI experience doesn't degrade. For now I'm just testing the water - feedback is very welcome.
Checklist