QUIC APL: Tick on SSL_read failure in non-blocking mode #21381
Closed
+16
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlandau
added
branch: master
paulidale
approved these changes
Jul 7, 2023
paulidale
removed
the
approval: otc review pending
t8m
approved these changes
Jul 7, 2023
t8m
added
approval: done
|
@hlandau Do we want a testcase that exercises this? |
mattcaswell
approved these changes
Jul 7, 2023
mattcaswell
added
tests: deferred
I spotted this problem while writing the test in #21367. There's a code comment about it in that test along with a workaround. I'd suggest we merge this as-is, and then I can update #21367 to remove the work around and that should serve as a test. Changing this to "tests:deferred" |
t8m
approved these changes
Jul 7, 2023
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
|
Merged. |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 9, 2023
... Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #21381)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, SSL_read in non-blocking mode should tick if we have no data to return.
Fixes #21365.