speed: Also measure RSA encrypt/decrypt, not only RSA sign/verify #21383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t8m
added
branch: master
paulidale
approved these changes
Jul 10, 2023
paulidale
removed
the
approval: otc review pending
t8m
reviewed
Jul 10, 2023
While RSA encrypt/decrypt and sign/verify are basically the same mod-expo operations, the speed of the operation may still differ, due to different padding, as well as the use of implicit rejection for RSA decrypt. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>
Always report "<algo> ops in <time>", instead of "<algo>'s in <time>" or similar. Avoid the use of apostrophes and/or plural with algorithm names. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>
ifranzki
force-pushed
the
speed-rsa-endecrypt
branch
from
3ae8252
to
6241aa6
Compare
|
Changed my commit to use Also changed the other algos to use this notation in a 2nd commit. Just in case you don't like that, we can easily drop this commit :-) |
paulidale
approved these changes
Jul 19, 2023
|
@t8m friendly ping ..... |
t8m
approved these changes
Jul 31, 2023
t8m
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to master branch. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Aug 1, 2023
While RSA encrypt/decrypt and sign/verify are basically the same mod-expo operations, the speed of the operation may still differ, due to different padding, as well as the use of implicit rejection for RSA decrypt. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #21383)
openssl-machine
pushed a commit
that referenced
this pull request
Aug 1, 2023
Always report "<algo> ops in <time>", instead of "<algo>'s in <time>" or similar. Avoid the use of apostrophes and/or plural with algorithm names. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #21383)
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Aug 2, 2023
While RSA encrypt/decrypt and sign/verify are basically the same mod-expo operations, the speed of the operation may still differ, due to different padding, as well as the use of implicit rejection for RSA decrypt. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#21383)
beldmit
pushed a commit
to beldmit/openssl
that referenced
this pull request
Aug 2, 2023
Always report "<algo> ops in <time>", instead of "<algo>'s in <time>" or similar. Avoid the use of apostrophes and/or plural with algorithm names. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#21383)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While RSA encrypt/decrypt and sign/verify are basically the same mod-expo operations, the speed of the operation may still differ, due to different padding, as well as the use of implicit rejection for RSA decrypt.