Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more fixes for WebAssembly/WASI build #21389

Closed
wants to merge 1 commit into from
Closed

Add more fixes for WebAssembly/WASI build #21389

wants to merge 1 commit into from

Conversation

loganek
Copy link
Contributor

@loganek loganek commented Jul 7, 2023

  • force use timegm - WASI does not have timezone tables
  • use basic implementation for OPENSSL_issetugid() - WASI doesn't support forking processes

CLA: trivial

Checklist
  • documentation is added or updated
  • tests are added or updated

@loganek loganek changed the title Add more fixes for fixing WebAssembly/WASI build Add more fixes for WebAssembly/WASI build Jul 7, 2023
@loganek
Add more fixes for WebAssembly/WASI build
8f07bde 
* force use timegm - WASI does not have timezone tables
* use basic implementation for `OPENSSL_issetugid()` - WASI doesn't support forking processes

CLA: trivial
@paulidale
Copy link
Contributor

okay with trivial.

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer cla: trivial One of the commits is marked as 'CLA: trivial' labels Jul 10, 2023
hlandau
hlandau approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@hlandau hlandau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with trivial

@hlandau hlandau added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jul 10, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jul 11, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor

Merged, thanks for the contribution.

@paulidale paulidale closed this Jul 12, 2023
openssl-machine pushed a commit that referenced this pull request Jul 12, 2023
@loganek @paulidale
Add more fixes for WebAssembly/WASI build
66f61ec 
* force use timegm - WASI does not have timezone tables
* use basic implementation for `OPENSSL_issetugid()` - WASI doesn't support forking processes

CLA: trivial

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21389)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlandau hlandau hlandau approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial'
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@loganek @paulidale @openssl-machine @hlandau