Two CI failure fixes #21411
Closed
Two CI failure fixes #21411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pointers can be invalidated when the underlying BUF_MEM grows.
t8m
added
branch: master
mattcaswell
reviewed
Jul 10, 2023
| @@ -63,7 +63,7 @@ typedef struct ossl_record_layer_st OSSL_RECORD_LAYER; | |||
| * buffer of payload data in |buf| of length |buflen|. | |||
| */ | |||
| struct ossl_record_template_st { | |||
| int type; | |||
| unsigned char type; | |||
There was a problem hiding this comment.
To fix big endian failures as seen here: https://github.com/openssl/openssl/actions/runs/5507119256
There was a problem hiding this comment.
There could be alternative approaches however we IMO depend on the type being just one byte if not anywhere else then in the SSL_trace() call when it is invoked from the ssl message callback.
t8m
changed the title
paulidale
approved these changes
Jul 12, 2023
paulidale
removed
the
approval: otc review pending
hlandau
approved these changes
Jul 12, 2023
hlandau
added
approval: done
|
OK with urgent |
hlandau
added
approval: ready to merge
|
Merged to master branch. Thank you for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Jul 14, 2023
Pointers can be invalidated when the underlying BUF_MEM grows. Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #21411)
openssl-machine
pushed a commit
that referenced
this pull request
Jul 14, 2023
Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #21411)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ossl_quic_wire_encode_pkt_hdr(): Assign ptrs only on static buf wpkt
Pointers can be invalidated when the underlying BUF_MEM grows.
quicapitest: Fix SSL_trace() test on big endian platforms
The structure member (of int type) is used as single byte value which works only on little endian platforms. Use the correct type.