Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no-srtp build failure #21412

Closed
wants to merge 1 commit into from
Closed

Fix no-srtp build failure #21412

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Jul 10, 2023

SRTP related functions aren't available when built with no-srtp.

@t8m
Fix no-srtp build failure
73fa402 
SRTP related functions aren't available when built with no-srtp.
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing labels Jul 10, 2023
@mattcaswell
Copy link
Member

Agree urgent

@mattcaswell mattcaswell removed the approval: otc review pending This pull request needs review by an OTC member label Jul 10, 2023
tmshort
tmshort approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@tmshort tmshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve. Agree urgent.

@tmshort tmshort added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jul 11, 2023
@tmshort
Copy link
Contributor

tmshort commented Jul 11, 2023

Merged!

@tmshort tmshort closed this Jul 11, 2023
openssl-machine pushed a commit that referenced this pull request Jul 11, 2023
@t8m @tmshort
Fix no-srtp build failure
9f3cd80 
SRTP related functions aren't available when built with no-srtp.

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Todd Short <todd.short@me.com>
(Merged from #21412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcaswell mattcaswell mattcaswell approved these changes

@tmshort tmshort tmshort approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t8m @mattcaswell @tmshort