Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFCI] Move Keccak rhotates tables to rodata #21440

Closed
wants to merge 1 commit into from
Closed

[NFCI] Move Keccak rhotates tables to rodata #21440

wants to merge 1 commit into from

Conversation

aaupov
Copy link
Contributor

@aaupov aaupov commented Jul 12, 2023

rhotates tables are placed to .text section which confuses tools such as BOLT.
Move them to rodata to unbreak and avoid polluting icache/iTLB with data.

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Jul 12, 2023
paulidale
paulidale approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay with calling this trivial.
If you agree, please amend the commit to include a line CLA: trivial at the end.

@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing labels Jul 12, 2023
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Jul 12, 2023
@aaupov
Move Keccak rhotates tables to rodata
0ed724e 
rhotates tables are placed to .text section which confuses tools such as BOLT.
Move them to rodata to unbreak and avoid polluting icache/iTLB with data.

CLA: trivial
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Jul 12, 2023
InfoHunter
InfoHunter approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@InfoHunter InfoHunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's trivial

@InfoHunter InfoHunter added approval: done This pull request has the required number of approvals cla: trivial One of the commits is marked as 'CLA: trivial' and removed approval: review pending This pull request needs review by a committer labels Jul 13, 2023
@aaupov aaupov mentioned this pull request Jul 13, 2023
Closed
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jul 14, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor

Merged to all three branches. Thanks for the fix.

@paulidale paulidale closed this Jul 14, 2023
openssl-machine pushed a commit that referenced this pull request Jul 14, 2023
@aaupov @paulidale
Move Keccak rhotates tables to rodata
2fd82c2 
rhotates tables are placed to .text section which confuses tools such as BOLT.
Move them to rodata to unbreak and avoid polluting icache/iTLB with data.

CLA: trivial

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Paul Yang <kaishen.yy@antfin.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21440)
openssl-machine pushed a commit that referenced this pull request Jul 14, 2023
@aaupov @paulidale
Move Keccak rhotates tables to rodata
2424348 
rhotates tables are placed to .text section which confuses tools such as BOLT.
Move them to rodata to unbreak and avoid polluting icache/iTLB with data.

CLA: trivial

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Paul Yang <kaishen.yy@antfin.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21440)

(cherry picked from commit 2fd82c2)
openssl-machine pushed a commit that referenced this pull request Jul 14, 2023
@aaupov @paulidale
Move Keccak rhotates tables to rodata
076243e 
rhotates tables are placed to .text section which confuses tools such as BOLT.
Move them to rodata to unbreak and avoid polluting icache/iTLB with data.

CLA: trivial

Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Paul Yang <kaishen.yy@antfin.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21440)

(cherry picked from commit 2fd82c2)
aaupov added a commit to aaupov/XKCP that referenced this pull request Jan 17, 2024
@aaupov
[NFCI] Move Keccak rhotates tables to rodata
f9bd228 
rhotates tables are added to .text section which confuses tools such as
BOLT. Move them to rodata to unbreak and avoid polluting icache/iTLB
with data.

Fix in OpenSSL openssl/openssl#21440
@aaupov aaupov mentioned this pull request Jan 17, 2024
Merged
gvanas pushed a commit to XKCP/XKCP that referenced this pull request Feb 29, 2024
@aaupov @gvanas
[NFCI] Move Keccak rhotates tables to rodata
c372d26 
rhotates tables are added to .text section which confuses tools such as
BOLT. Move them to rodata to unbreak and avoid polluting icache/iTLB
with data.

Fix in OpenSSL openssl/openssl#21440
aaupov added a commit to aaupov/liboqs that referenced this pull request Mar 27, 2024
@aaupov
[NFCI] Move Keccak rhotates tables to rodata
6b8b1a3 
rhotates tables are placed to .text section which confuses tools such as
BOLT. Move them to rodata to unbreak and avoid polluting icache/iTLB
with data.

Sync with XKCP upstream: XKCP/XKCP#137
Similar fix in OpenSSL: openssl/openssl#21440

1. Update patch file using the steps in scripts/copy_from_xkcp/README
2. Apply the updated patch with scripts/copy_from_xkcp/package.sh
aaupov added a commit to aaupov/liboqs that referenced this pull request Mar 27, 2024
@aaupov
[NFCI] Move Keccak rhotates tables to rodata
5f52fc8 
rhotates tables are placed to .text section which confuses tools such as
BOLT. Move them to rodata to unbreak and avoid polluting icache/iTLB
with data.

1. Update patch file using the steps in scripts/copy_from_xkcp/README
2. Apply the updated patch with scripts/copy_from_xkcp/package.sh

Sync with XKCP upstream: XKCP/XKCP#137
Similar fix in OpenSSL: openssl/openssl#21440
Redo of open-quantum-safe#1508
@aaupov aaupov mentioned this pull request Mar 27, 2024
Merged
2 tasks
aaupov added a commit to aaupov/liboqs that referenced this pull request Mar 27, 2024
@aaupov
[NFCI] Move Keccak rhotates tables to rodata
1d85eed 
rhotates tables are placed to .text section which confuses tools such as
BOLT. Move them to rodata to unbreak and avoid polluting icache/iTLB
with data.

1. Update patch file using the steps in scripts/copy_from_xkcp/README
2. Apply the updated patch with scripts/copy_from_xkcp/package.sh

Sync with XKCP upstream: XKCP/XKCP#137
Similar fix in OpenSSL: openssl/openssl#21440
Redo of open-quantum-safe#1508

Signed-off-by: Amir Ayupov <aaupov@fb.com>
dstebila pushed a commit to open-quantum-safe/liboqs that referenced this pull request Apr 2, 2024
@aaupov @dstebila
[NFCI] Move Keccak rhotates tables to rodata
3dd478e 
rhotates tables are placed to .text section which confuses tools such as
BOLT. Move them to rodata to unbreak and avoid polluting icache/iTLB
with data.

1. Update patch file using the steps in scripts/copy_from_xkcp/README
2. Apply the updated patch with scripts/copy_from_xkcp/package.sh

Sync with XKCP upstream: XKCP/XKCP#137
Similar fix in OpenSSL: openssl/openssl#21440
Redo of #1508

Signed-off-by: Amir Ayupov <aaupov@fb.com>
Eddy-M-K pushed a commit to Eddy-M-K/liboqs that referenced this pull request Apr 5, 2024
@aaupov @Eddy-M-K
[NFCI] Move Keccak rhotates tables to rodata
5ccbdf7 
rhotates tables are placed to .text section which confuses tools such as
BOLT. Move them to rodata to unbreak and avoid polluting icache/iTLB
with data.

1. Update patch file using the steps in scripts/copy_from_xkcp/README
2. Apply the updated patch with scripts/copy_from_xkcp/package.sh

Sync with XKCP upstream: XKCP/XKCP#137
Similar fix in OpenSSL: openssl/openssl#21440
Redo of open-quantum-safe#1508

Signed-off-by: Amir Ayupov <aaupov@fb.com>
Signed-off-by: Eddy Kim <Eddy.M.Kim@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InfoHunter InfoHunter InfoHunter approved these changes

@hlandau hlandau hlandau approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 cla: trivial One of the commits is marked as 'CLA: trivial' severity: fips change The pull request changes FIPS provider sources tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aaupov @openssl-machine @paulidale @InfoHunter @hlandau