Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos found by codespell #21467

Closed

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Jul 16, 2023

About re-usereuse: reuse is found in all dictionaries, and more importantly, it already occurs > 100 times in the repository, so this is more a question of consistency than correctness.

Not sure about implementorimplementer. Both seem acceptable, but most dictionaries suggest implementer alone or as a first choice (Cambridge, Merriam-Webster) and the Google Books Ngram database suggests that implementer outdistanced implementor around 2000, and curiously even more in American than British English:
https://books.google.com/ngrams/graph?content=implementer%2Cimplementor&year_start=1800&year_end=2019&corpus=en-2019

Checklist
  • documentation is added or updated
  • tests are added or updated

@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Jul 16, 2023
@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer tests: exempted The PR is exempt from requirements for testing labels Jul 16, 2023
@hlandau hlandau removed the approval: review pending This pull request needs review by a committer label Jul 17, 2023
@paulidale paulidale added the approval: done This pull request has the required number of approvals label Jul 17, 2023
@t8m t8m added the triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly label Jul 17, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jul 18, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor

Merged, thanks for the documentation fixes.

@paulidale paulidale closed this Jul 18, 2023
openssl-machine pushed a commit that referenced this pull request Jul 18, 2023
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21467)
@DimitriPapadopoulos DimitriPapadopoulos deleted the codespell branch July 18, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch severity: fips change The pull request changes FIPS provider sources tests: exempted The PR is exempt from requirements for testing triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants