Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KDF doc: expand on 'salt' and 'info' parameters #21469

Closed
wants to merge 9 commits into from
Closed

KDF doc: expand on 'salt' and 'info' parameters #21469

wants to merge 9 commits into from

Conversation

DDvO
Copy link
Contributor

@DDvO DDvO commented Jul 16, 2023

  • EVP_KDF.pod: extend text on 'salt' and 'info' parameters
  • openssl-kdf.pod.in: add text on 'salt' and 'info' parameters; small further improvements

@DDvO DDvO added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: documentation The issue/pr deals with documentation (errors) branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 labels Jul 16, 2023
@DDvO DDvO changed the title Improve KDF doc KDF doc: expand on 'salt' and 'info' parameters Jul 16, 2023
@paulidale paulidale removed the approval: otc review pending This pull request needs review by an OTC member label Jul 16, 2023
@DDvO
Copy link
Contributor Author

DDvO commented Jul 17, 2023

Thanks for your swift reviews and @slontis for your comments.
I've handled them; @paulidale wanna reapprove?

slontis
slontis reviewed Jul 17, 2023
View reviewed changes
doc/man3/EVP_KDF.pod Outdated Show resolved Hide resolved
paulidale
paulidale reviewed Jul 17, 2023
View reviewed changes
doc/man1/openssl-kdf.pod.in Outdated Show resolved Hide resolved
doc/man3/EVP_KDF.pod Outdated Show resolved Hide resolved
@DDvO
Copy link
Contributor Author

DDvO commented Jul 17, 2023

General question on such doc-only PRs:
Should anyone place the tests:exempted label?
For such cases I miss a tests:not applicable label.

@t8m
Copy link
Member

t8m commented Jul 17, 2023

General question on such doc-only PRs: Should anyone place the tests:exempted label? For such cases I miss a tests:not applicable label.

tests: exempted has the exact meaning. Yeah, we do not distinguish between the cases where the test would be unproportionally hard to write and when there is nothing to test here.

@DDvO DDvO added the tests: exempted The PR is exempt from requirements for testing label Jul 17, 2023
t8m
t8m approved these changes Jul 17, 2023
View reviewed changes
Copy link
Member

@t8m t8m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paulidale please reconfirm

@paulidale paulidale added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Jul 17, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jul 19, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

openssl-machine pushed a commit that referenced this pull request Jul 19, 2023
@DDvO @paulidale
EVP_KDF.pod: extend text on 'salt' and 'info' parameters
61c8146 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21469)
openssl-machine pushed a commit that referenced this pull request Jul 19, 2023
@DDvO @paulidale
openssl-kdf.pod.in: add text on 'salt' and 'info' parameters; small f…
7b2a3a1 
…urther improvements

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21469)
@paulidale
Copy link
Contributor

Merged, thanks.

@paulidale paulidale closed this Jul 19, 2023
openssl-machine pushed a commit that referenced this pull request Jul 19, 2023
@DDvO @paulidale
EVP_KDF.pod: extend text on 'salt' and 'info' parameters
e4781ea 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21469)

(cherry picked from commit 61c8146)
openssl-machine pushed a commit that referenced this pull request Jul 19, 2023
@DDvO @paulidale
openssl-kdf.pod.in: add text on 'salt' and 'info' parameters; small f…
6e4aad6 
…urther improvements

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21469)

(cherry picked from commit 7b2a3a1)
openssl-machine pushed a commit that referenced this pull request Jul 19, 2023
@DDvO @paulidale
EVP_KDF.pod: extend text on 'salt' and 'info' parameters
4316c64 
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21469)

(cherry picked from commit 61c8146)
openssl-machine pushed a commit that referenced this pull request Jul 19, 2023
@DDvO @paulidale
openssl-kdf.pod.in: add text on 'salt' and 'info' parameters; small f…
2c09df2 
…urther improvements

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21469)

(cherry picked from commit 7b2a3a1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slontis slontis slontis left review comments

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm left review comments

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@DDvO @t8m @openssl-machine @paulidale @slontis @tom-cosgrove-arm