Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clang-6,7,8 strict build #21501

Closed
wants to merge 1 commit into from
Closed

fix clang-6,7,8 strict build #21501

wants to merge 1 commit into from

Conversation

marcoabbadini
Copy link
Contributor

Fix #21477 Clang strict build initialization

CLA: trivial

Checklist
  • documentation is added or updated
  • tests are added or updated

kroeckx
kroeckx approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@kroeckx kroeckx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also be find with just removing the initialization.

@paulidale paulidale added approval: done This pull request has the required number of approvals branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug cla: trivial One of the commits is marked as 'CLA: trivial' branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing labels Jul 20, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Jul 22, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale paulidale removed branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 labels Jul 23, 2023
@paulidale
Copy link
Contributor

Merged, thanks for the contribution.

@paulidale paulidale closed this Jul 23, 2023
openssl-machine pushed a commit that referenced this pull request Jul 23, 2023
@marcoabbadini @paulidale
fix clang-6,7,8 strict build
6cac1ce 
CLA: trivial

Reviewed-by: Kurt Roeckx <kurt@roeckx.be>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21501)
@t8m
Copy link
Member

t8m commented Jul 24, 2023

There is one more place where this is happening @marcoabbadini would you like to submit another similar PR?

@marcoabbadini
Copy link
Contributor Author

Hi @t8m , sure! Can you give me more info? Thanks.

@t8m
Copy link
Member

t8m commented Jul 24, 2023 •
edited

You can see the failure here https://github.com/openssl/openssl/actions/runs/5639168434/job/15274035791

@trigpolynom
Copy link
Contributor

hi @marcoabbadini if this hasn't been fixed yet I'd like to take a stab at it!

@trigpolynom trigpolynom mentioned this pull request Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kroeckx kroeckx kroeckx approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clang-6,7,8 versions fail strict builds due to missing brackets in initialization
6 participants
@marcoabbadini @openssl-machine @paulidale @t8m @trigpolynom @kroeckx