New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a sig algs bug and add some tests #2160
Conversation
This macro has a typo in it which makes it unusable. This issue was already fixed in 1.0.2 in commit 75fdee0, but the same fix was not applied to other branches.
+1 with minor comment fix applied |
We need a new API for TLSv1.3 sig algs
a0f04fb
to
1f9f595
Compare
I pushed a new version to fix a travis failure (variables in the new test were not declared static). I also fixed the comment while I was at it. @t-j-h please reconfirm |
I dont see any new commits on this pull request since my +1 - am I missing something? |
I modified the existing commits and force pushed. The only difference is the comment change and all these variables are now declared static where they weren't before:
|
+1 |
Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from #2160)
We need a new API for TLSv1.3 sig algs Reviewed-by: Tim Hudson <tjh@openssl.org> (Merged from #2160)
Pushed. Thanks. |
Checklist
Description of change
This PR fixes a bug in the SSL_set1_sigalgs() macro. Prior to this fix, use of the macro results in a compilation failure. The bug was actually already fixed once in commit 75fdee0, but the fix was only applied to the 1.0.2 branch for some reason.
I've also added some tests for this.
The first 2 commits are for 1.1.0 and master. The third commit is only for master as it is TLSv1.3 specific.