Fix the recent daily runchecker CI failures related to QUIC #21677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes openssl#21624 With OPENSSL_NO_POSIX_IO or OPENSSL_NO_SOCK the function wait_until_sock_readable() does not exist.
as both algorithms are really needed. Fixes openssl#21625
t8m
added
branch: master
Also do not build quicserver with no-stdio as it is a test utility and tests are disabled with no-stdio anyway.
kroeckx
reviewed
Aug 7, 2023
kroeckx
reviewed
Aug 7, 2023
hlandau
requested changes
Aug 8, 2023
Revert "quicapitest.c: Do not use undefined function" Define empty wait_until_sock_readable() when building with no-posix-io.
| on: | ||
| schedule: | ||
| - cron: '0 6 * * *' | ||
| on: [pull_request] |
There was a problem hiding this comment.
Is this change just temporary while the PR is being worked on?
There was a problem hiding this comment.
Yes - it is in a commit marked with drop!
hlandau
approved these changes
Aug 9, 2023
hlandau
removed
the
approval: otc review pending
tom-cosgrove-arm
added
approval: done
|
Note for merging: Do not forget to drop the commit marked drop! |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
|
Merged to master branch. Thank you for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Aug 14, 2023
Fixes #21624 With OPENSSL_NO_POSIX_IO or OPENSSL_NO_SOCK the function wait_until_sock_readable() currently does not exist. Define empty wait_until_sock_readable() when building with no-posix-io. Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> (Merged from #21677)
openssl-machine
pushed a commit
that referenced
this pull request
Aug 14, 2023
Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> (Merged from #21677)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21623 #21624 #21625 #21626