QUIC: Raise more errors when appropriate #21700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t8m
added
branch: master
|
CI failures are relevant |
Fixed |
h-vetinari
reviewed
Aug 9, 2023
mattcaswell
requested changes
Aug 10, 2023
hlandau
requested changes
Aug 10, 2023
There was a problem hiding this comment.
Generally good stuff. @mattcaswell's comments apply. The TXP change needs to be reverted and all raising in quic_impl.c should use one of the RAISE macros, defining a new non-I/O one if desired.
t8m
removed
approval: review pending
This was already resolved by openssl#21547
This improves tracking where the failure was triggered.
Raise errors when appropriate.
Even in case of later failure we need to flush the previous packets.
t8m
added
approval: review pending
|
Ready for re-review. |
hlandau
approved these changes
Aug 21, 2023
hlandau
removed
the
approval: otc review pending
|
Ping @openssl/committers for second review |
mattcaswell
approved these changes
Aug 22, 2023
mattcaswell
removed
the
approval: review pending
mattcaswell
added
the
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Merged to master branch. Thank you for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Aug 23, 2023
This improves tracking where the failure was triggered. Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #21700)
openssl-machine
pushed a commit
that referenced
this pull request
Aug 23, 2023
Raise errors when appropriate. Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #21700)
openssl-machine
pushed a commit
that referenced
this pull request
Aug 23, 2023
Even in case of later failure we need to flush the previous packets. Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #21700)
openssl-machine
pushed a commit
that referenced
this pull request
Aug 23, 2023
Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #21700)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are probably more places where we could raise errors but this should be sufficient for MVP.