Fix some combinations of no-* options #21722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcaswell
added
branch: master
hlandau
approved these changes
Aug 11, 2023
hlandau
removed
the
approval: otc review pending
|
@hlandau - please reconfirm |
tom-cosgrove-arm
added
approval: done
mattcaswell
added
approval: review pending
hlandau
approved these changes
Aug 14, 2023
hlandau
added
approval: done
t8m
approved these changes
Aug 14, 2023
|
What is the context of these changes.. i.e. Is there existing tests that picked this issue up? |
In this comment I talked about a set of options that could be used to try and minimise the size of the openssl executable in order to just be able to use fipsinstall: But when I tried to use them I saw the compile errors I'm fixing here. |
|
CI failure does not seem relevant. @hlandau - CI failure was a multistream test script 12 failure....have we seen that one before? |
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
t8m
removed
the
approval: done
t8m
added
the
approval: ready to merge
openssl-machine
pushed a commit
that referenced
this pull request
Aug 15, 2023
Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #21722)
openssl-machine
pushed a commit
that referenced
this pull request
Aug 15, 2023
Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #21722)
|
Merged to master, 3.1, and 3.0 branches. Thank you |
xl32
pushed a commit
to xl32/openssl
that referenced
this pull request
Sep 29, 2023
Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#21722) (cherry picked from commit fb32f6e)
xl32
pushed a commit
to xl32/openssl
that referenced
this pull request
Sep 29, 2023
Reviewed-by: Hugo Landau <hlandau@openssl.org> Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#21722) (cherry picked from commit 4efd84f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix no-dtls in combination with no-tls.
Fix no-dsa in combination with no-err.