Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add X509_STORE_CTX_set_get_crl and X509_STORE_CTX_set_current_reasons #21737

Closed
wants to merge 1 commit into from
Closed

Add X509_STORE_CTX_set_get_crl and X509_STORE_CTX_set_current_reasons #21737

wants to merge 1 commit into from

Conversation

vm-vloz
Copy link
Contributor

@vm-vloz vm-vloz commented Aug 14, 2023

This change is for feature request #21679.

Adds a couple of setters to aid with custom CRL validation.

  • documentation is added or updated

@t8m t8m added branch: master Merge to master branch triaged: feature The issue/pr requests/adds a feature labels Aug 14, 2023
@t8m t8m added approval: review pending This pull request needs review by a committer tests: exempted The PR is exempt from requirements for testing labels Aug 14, 2023
@vm-vloz
Add X509_STORE_CTX_set_get_crl and X509_STORE_CTX_set_current_reasons
741434b 
This change is for feature request openssl#21679.

Adds a couple of setters to aid with custom CRL validation.
@tmshort tmshort added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Aug 16, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Aug 17, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Aug 17, 2023

Merged to master branch. Thank you for your contribution.

@t8m t8m closed this Aug 17, 2023
openssl-machine pushed a commit that referenced this pull request Aug 17, 2023
@vm-vloz @t8m
Add X509_STORE_CTX_set_get_crl and X509_STORE_CTX_set_current_reasons
4a469cb 
This change is for feature request #21679.

Adds a couple of setters to aid with custom CRL validation.

Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@tmshort tmshort tmshort approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: exempted The PR is exempt from requirements for testing triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vm-vloz @openssl-machine @t8m @tmshort