Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quic_new_record_layer(): Change TODO(QUIC) to QUIC FUTURE #21756

Closed
wants to merge 1 commit into from
Closed

quic_new_record_layer(): Change TODO(QUIC) to QUIC FUTURE #21756

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Aug 16, 2023

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly tests: exempted The PR is exempt from requirements for testing labels Aug 16, 2023
@mattcaswell mattcaswell removed the approval: otc review pending This pull request needs review by an OTC member label Aug 16, 2023
@hlandau hlandau added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Aug 17, 2023
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@t8m
Copy link
Member Author

t8m commented Aug 18, 2023

Merged to master branch. Thank you for the reviews.

@t8m t8m closed this Aug 18, 2023
openssl-machine pushed a commit that referenced this pull request Aug 18, 2023
@t8m
quic_new_record_layer(): Change TODO(QUIC) to QUIC FUTURE
79cdbe8 
Fixes openssl/project#134

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from #21756)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlandau hlandau hlandau approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch tests: exempted The PR is exempt from requirements for testing triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve TODO(QUIC) about bad cast in quic_new_record_layer()
4 participants
@t8m @openssl-machine @hlandau @mattcaswell