Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused variable #21768

Closed
wants to merge 2 commits into from
Closed

Remove unused variable #21768

wants to merge 2 commits into from

Conversation

shub-al
Copy link
Contributor

@shub-al shub-al commented Aug 17, 2023

CLA: trivial
OpenSSL 3.0, 3.1, master

The content of the variable single in function ssl_get_min_max_version is really not used anywhere.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

@shub-al
Update statem_lib.c
415edbf 
CLA: trivial
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer cla: trivial One of the commits is marked as 'CLA: trivial' triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly tests: exempted The PR is exempt from requirements for testing labels Aug 17, 2023
@t8m
Copy link
Member

t8m commented Aug 17, 2023

OK with CLA: trivial given this is in practice a removal of code only.

tom-cosgrove-arm
tom-cosgrove-arm approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Okay with trivial

@tom-cosgrove-arm tom-cosgrove-arm added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Aug 17, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Aug 18, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Aug 20, 2023

Merged to master branch. Thank you for your contribution.

@t8m t8m closed this Aug 20, 2023
openssl-machine pushed a commit that referenced this pull request Aug 20, 2023
@shub-al @t8m
ssl_get_min_max_version(): Remove unused variable single
d561fe5 
CLA: trivial

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21768)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@tom-cosgrove-arm tom-cosgrove-arm tom-cosgrove-arm approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' tests: exempted The PR is exempt from requirements for testing triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shub-al @t8m @openssl-machine @tom-cosgrove-arm