Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes unused member read_iv of ossl_record_layer_st. #21804

Closed
wants to merge 1 commit into from
Closed

Removes unused member read_iv of ossl_record_layer_st. #21804

wants to merge 1 commit into from

Conversation

fwh-dc
Copy link
Contributor

@fwh-dc fwh-dc commented Aug 22, 2023

Fixes #21732

@openssl-machine openssl-machine added the hold: cla required The contributor needs to submit a license agreement label Aug 22, 2023
@mattcaswell mattcaswell added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member labels Aug 22, 2023
@t8m t8m added the triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly label Aug 22, 2023
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member labels Aug 22, 2023
@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually.

@t8m t8m closed this Aug 29, 2023
@t8m t8m reopened this Aug 29, 2023
@openssl-machine openssl-machine removed the hold: cla required The contributor needs to submit a license agreement label Aug 29, 2023
@t8m t8m added tests: exempted The PR is exempt from requirements for testing approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Aug 29, 2023
@t8m
Copy link
Member

t8m commented Aug 29, 2023

Merged to the master branch. Thank you for your contribution.

@t8m t8m closed this Aug 29, 2023
openssl-machine pushed a commit that referenced this pull request Aug 29, 2023
@fwh-dc @t8m
Removed unused member read_iv of ossl_record_layer_st
20a54aa 
Fixes #21732

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21804)
heygauri pushed a commit to heygauri/openssl that referenced this pull request Sep 1, 2023
@fwh-dc @heygauri
Removed unused member read_iv of ossl_record_layer_st
a0b2abe 
Fixes openssl#21732

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#21804)
@fwh-dc fwh-dc deleted the fixes-21732 branch October 2, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: exempted The PR is exempt from requirements for testing triaged: cleanup The issue/pr deals with cleanup of comments/docs not altering code significantly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Safe to delete member of ossl_record_layer_st: read_iv?
4 participants
@fwh-dc @openssl-machine @t8m @mattcaswell