Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ctrl_params_translate: Allow RSA controls also for RSA-PSS #21818

Closed
wants to merge 2 commits into from
Closed

ctrl_params_translate: Allow RSA controls also for RSA-PSS #21818

wants to merge 2 commits into from

Conversation

ifranzki
Copy link
Contributor

Checklist
  • tests are added or updated

Closes: #21813

@ifranzki
ctrl_params_translate: Allow RSA controls also for RSA-PSS
6a0bb50 
Controls 'rsa_keygen_pubexp' and 'rsa_keygen_primes' should also be allowed
for RSA-PSS keys.

Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>
@ifranzki
ctrl_params_translate: Allow get_rsa_payload_x() also for RSA-PSS
73d5385 
The get_rsa_payload_x() functions should also allow to get the payload
for RSA-PSS keys.

Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>
@ifranzki ifranzki mentioned this pull request Aug 23, 2023
Closed
@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: present The PR has suitable tests present labels Aug 23, 2023
@t8m t8m removed the approval: otc review pending This pull request needs review by an OTC member label Aug 23, 2023
@ifranzki
Copy link
Contributor Author

That one test case failure seems unrelated.

@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Aug 23, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Aug 24, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Aug 24, 2023

Merged to master, 3.1, and 3.0 branches. Thank you for your contribution.

@t8m t8m closed this Aug 24, 2023
openssl-machine pushed a commit that referenced this pull request Aug 24, 2023
@ifranzki @t8m
ctrl_params_translate: Allow RSA controls also for RSA-PSS
e2c2cca 
Controls 'rsa_keygen_pubexp' and 'rsa_keygen_primes' should also be allowed
for RSA-PSS keys.

Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21818)
openssl-machine pushed a commit that referenced this pull request Aug 24, 2023
@ifranzki @t8m
ctrl_params_translate: Allow get_rsa_payload_x() also for RSA-PSS
cf71283 
The get_rsa_payload_x() functions should also allow to get the payload
for RSA-PSS keys.

Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21818)
openssl-machine pushed a commit that referenced this pull request Aug 24, 2023
@ifranzki @t8m
ctrl_params_translate: Allow RSA controls also for RSA-PSS
53dca2f 
Controls 'rsa_keygen_pubexp' and 'rsa_keygen_primes' should also be allowed
for RSA-PSS keys.

Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21818)

(cherry picked from commit e2c2cca)
openssl-machine pushed a commit that referenced this pull request Aug 24, 2023
@ifranzki @t8m
ctrl_params_translate: Allow get_rsa_payload_x() also for RSA-PSS
bf7021d 
The get_rsa_payload_x() functions should also allow to get the payload
for RSA-PSS keys.

Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21818)

(cherry picked from commit cf71283)
openssl-machine pushed a commit that referenced this pull request Aug 24, 2023
@ifranzki @t8m
ctrl_params_translate: Allow RSA controls also for RSA-PSS
cb462f9 
Controls 'rsa_keygen_pubexp' and 'rsa_keygen_primes' should also be allowed
for RSA-PSS keys.

Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21818)

(cherry picked from commit e2c2cca)
openssl-machine pushed a commit that referenced this pull request Aug 24, 2023
@ifranzki @t8m
ctrl_params_translate: Allow get_rsa_payload_x() also for RSA-PSS
313fdbb 
The get_rsa_payload_x() functions should also allow to get the payload
for RSA-PSS keys.

Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21818)

(cherry picked from commit cf71283)
xl32 pushed a commit to xl32/openssl that referenced this pull request Sep 29, 2023
@ifranzki @xl32
ctrl_params_translate: Allow RSA controls also for RSA-PSS
4d0ed2b 
Controls 'rsa_keygen_pubexp' and 'rsa_keygen_primes' should also be allowed
for RSA-PSS keys.

Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#21818)

(cherry picked from commit e2c2cca)
xl32 pushed a commit to xl32/openssl that referenced this pull request Sep 29, 2023
@ifranzki @xl32
ctrl_params_translate: Allow get_rsa_payload_x() also for RSA-PSS
4effb6c 
The get_rsa_payload_x() functions should also allow to get the payload
for RSA-PSS keys.

Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl#21818)

(cherry picked from commit cf71283)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch branch: 3.0 Merge to openssl-3.0 branch branch: 3.1 Merge to openssl-3.1 tests: present The PR has suitable tests present triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

openssl genpkey with RSA-PSS does not accept -pkeyopt rsa_keygen_pubexp:65537
4 participants
@ifranzki @openssl-machine @t8m @mattcaswell