Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for OS Zoo CI failure on Alpine containers #21825

Closed
wants to merge 3 commits into from
Closed

Fix for OS Zoo CI failure on Alpine containers #21825

wants to merge 3 commits into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Aug 23, 2023

No description provided.

@t8m t8m added branch: master Merge to master branch triaged: bug The issue/pr is/fixes a bug labels Aug 23, 2023
@t8m t8m added approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member tests: exempted The PR is exempt from requirements for testing labels Aug 23, 2023
@t8m t8m marked this pull request as ready for review August 23, 2023 21:29
@t8m
Copy link
Member Author

t8m commented Aug 23, 2023

drop! commit to be dropped when merging.

@t8m t8m linked an issue Aug 24, 2023 that may be closed by this pull request
OS Zoo CI fails with Alpine containers on 80-test_cmp_http.t #21824
Closed
@t8m t8m mentioned this pull request Aug 24, 2023
Closed
@t8m t8m requested review from DDvO and a team August 24, 2023 07:28
DDvO
DDvO approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@DDvO DDvO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t8m t8m removed the approval: review pending This pull request needs review by a committer label Aug 24, 2023
@hlandau hlandau added approval: done This pull request has the required number of approvals and removed approval: otc review pending This pull request needs review by an OTC member labels Aug 24, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Aug 25, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@hlandau
Copy link
Member

hlandau commented Aug 25, 2023

Merged to master. Thank you.

@hlandau hlandau closed this Aug 25, 2023
openssl-machine pushed a commit that referenced this pull request Aug 25, 2023
@t8m @hlandau
The canonical localhost IPv6 address is [::1] not [::]
7a12e7a 
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #21825)
openssl-machine pushed a commit that referenced this pull request Aug 25, 2023
@t8m @hlandau
drop! Make OS Zoo on pull request to test
467e5c1 
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #21825)
openssl-machine pushed a commit that referenced this pull request Aug 25, 2023
@t8m @hlandau
80-test_cmp_http.t: Skip IPv6 address test if IPv6 is unavailable
56562c4 
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: David von Oheimb <david.von.oheimb@siemens.com>
(Merged from #21825)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlandau hlandau hlandau approved these changes

@DDvO DDvO DDvO approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OS Zoo CI fails with Alpine containers on 80-test_cmp_http.t
4 participants
@t8m @openssl-machine @hlandau @DDvO