QUIC: Run multistream tests in blocking mode as well #21827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlandau
added
branch: master
hlandau
force-pushed
the
quic-test-blocking
branch
2 times, most recently
from
94b8273
to
4a3f1f2
Compare
|
CI still relevant |
|
Yeah, I'm investigating. |
hlandau
force-pushed
the
quic-test-blocking
branch
from
2d17a94
to
241e163
Compare
|
Hmm... it seems it still doesn't work properly on Windows. |
|
This is due to our Windows code not having an implementation of |
This comment was marked as spam.
This comment was marked as spam.
hlandau
force-pushed
the
quic-test-blocking
branch
from
241e163
to
8dea3f8
Compare
github-actions
bot
added
the
severity: fips change
hlandau
force-pushed
the
quic-test-blocking
branch
from
7216ffa
to
b7f141a
Compare
|
Updated and rebased, CI passing, ready for review. This adds a new Win32 pre-Vista condition variable emulation algorithm, and tests on Windows are now passing. |
|
Needs another rebase |
|
Rebased |
hlandau
force-pushed
the
quic-test-blocking
branch
from
b7f141a
to
dcd643b
Compare
mattcaswell
requested changes
Sep 4, 2023
|
Hmmm....is CI failure relevant? |
It doesn't look like it. Updated. |
t8m
approved these changes
Sep 4, 2023
t8m
removed
the
approval: otc review pending
mattcaswell
approved these changes
Sep 5, 2023
mattcaswell
added
approval: done
|
24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually. |
|
Merged to master. Thanks for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Sep 6, 2023
…ing modes Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #21827)
openssl-machine
pushed a commit
that referenced
this pull request
Sep 6, 2023
Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #21827)
openssl-machine
pushed a commit
that referenced
this pull request
Sep 6, 2023
Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #21827)
openssl-machine
pushed a commit
that referenced
this pull request
Sep 6, 2023
Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #21827)
openssl-machine
pushed a commit
that referenced
this pull request
Sep 6, 2023
Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #21827)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the multistream test to run everything in both blocking and non-blocking mode using the same set of scripts. This should dramatically increase our test coverage for our APIs in blocking mode.
Internally this works by spinning up an extra thread to tick the TSERVER so that we can enter a blocking call in the main thread.
Built on the WAIT_PEER PR.