Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BIO_seek/BIO_tell from evp_test.c #2183

Closed
wants to merge 1 commit into from
Closed

Remove BIO_seek/BIO_tell from evp_test.c #2183

wants to merge 1 commit into from

Conversation

snhenson
Copy link
Contributor

@snhenson snhenson commented Jan 5, 2017 •
edited by levitte

BIO_seek and BIO_tell can cause problems with evp_test.c on some platforms.
Avoid them by using a temporary memory BIO to store key PEM data.

Checklist
  • CLA is signed
Description of change

@snhenson
Remove BIO_seek/BIO_tell from evp_test.c
23c0432 
BIO_seek and BIO_tell can cause problems with evp_test.c on some platforms.
Avoid them by using a temporary memory BIO to store key PEM data.
levitte
levitte approved these changes Jan 5, 2017
View reviewed changes
Copy link
Member

@levitte levitte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending the build results

@snhenson snhenson added 1.1.0 branch: master Merge to master branch labels Jan 5, 2017
levitte pushed a commit that referenced this pull request Jan 5, 2017
@snhenson
Remove BIO_seek/BIO_tell from evp_test.c
71f60ef 
BIO_seek and BIO_tell can cause problems with evp_test.c on some platforms.
Avoid them by using a temporary memory BIO to store key PEM data.

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #2183)
levitte pushed a commit that referenced this pull request Jan 5, 2017
@snhenson
Remove BIO_seek/BIO_tell from evp_test.c
0c0ead5 
BIO_seek and BIO_tell can cause problems with evp_test.c on some platforms.
Avoid them by using a temporary memory BIO to store key PEM data.

Reviewed-by: Richard Levitte <levitte@openssl.org>
(Merged from #2183)
(cherry picked from commit 71f60ef)
@snhenson snhenson closed this Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levitte levitte levitte approved these changes

Assignees
No one assigned
Labels
branch: master Merge to master branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@snhenson @levitte