Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the fixed size handling for dgram_pair and dgram_mem #21866

Closed
wants to merge 1 commit into from
Closed

Correct the fixed size handling for dgram_pair and dgram_mem #21866

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Aug 28, 2023

Checklist
  • tests are added or updated

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug tests: present The PR has suitable tests present labels Aug 28, 2023
@t8m
Copy link
Member Author

t8m commented Aug 28, 2023

Alternative to #21852

@t8m t8m requested a review from kroeckx August 28, 2023 09:33
@t8m t8m mentioned this pull request Aug 28, 2023
Closed
@hlandau hlandau removed the approval: otc review pending This pull request needs review by an OTC member label Aug 29, 2023
@mattcaswell mattcaswell added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Aug 29, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Aug 30, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@hlandau
Copy link
Member

hlandau commented Aug 30, 2023

Merged to master. Thank you.

@hlandau hlandau closed this Aug 30, 2023
openssl-machine pushed a commit that referenced this pull request Aug 30, 2023
@t8m @hlandau
Correct the fixed size handling for dgram_pair and dgram_mem
b56b034 
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from #21866)
heygauri pushed a commit to heygauri/openssl that referenced this pull request Sep 1, 2023
@t8m @heygauri
Correct the fixed size handling for dgram_pair and dgram_mem
ba85952 
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from openssl#21866)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlandau hlandau hlandau approved these changes

@mattcaswell mattcaswell mattcaswell approved these changes

@kroeckx kroeckx Awaiting requested review from kroeckx

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: present The PR has suitable tests present triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@t8m @openssl-machine @hlandau @mattcaswell