Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed unnecessary brace in ktls_configure_crypto #21908

Closed
wants to merge 1 commit into from
Closed

Removed unnecessary brace in ktls_configure_crypto #21908

wants to merge 1 commit into from

Conversation

minima1cha0s
Copy link
Contributor

Fixes #21498

CLA: trivial

@slontis
Copy link
Member

slontis commented Aug 31, 2023

It unfortunate that we don't even build this.. Looks like it might be possible via Macos+Virtualbox vm..
@openssl/otc would it be possible to use https://github.com/marketplace/actions/freebsd-vm, (MIT license might be an issue?)

@slontis slontis added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member labels Aug 31, 2023
@t8m t8m added triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing labels Aug 31, 2023
@t8m t8m added this to the 3.2.0 milestone Aug 31, 2023
@t8m t8m added severity: regression The issue/pr is a regression from previous released version cla: trivial One of the commits is marked as 'CLA: trivial' and removed approval: otc review pending This pull request needs review by an OTC member labels Aug 31, 2023
@t8m
Copy link
Member

t8m commented Aug 31, 2023

OK with CLA: trivial.

@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Aug 31, 2023
@t-j-h t-j-h added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Aug 31, 2023
@t-j-h
Copy link
Member

t-j-h commented Aug 31, 2023

Agree with CLA: trivial

@minima1cha0s
Copy link
Contributor Author

Hi, this is my first contribution, what does the red cross ❌️ beside the commit mean

@slontis
Copy link
Member

slontis commented Aug 31, 2023

The cross means the CI failed on a test. You can see which test failed above by clicking on the details. In this case it is a infrastructure issue that is not caused by your change. (So nothing you need to worry about).

@openssl-machine
Copy link
Collaborator

24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually.

@t8m
Copy link
Member

t8m commented Sep 1, 2023

Merged to the master branch. Thank you for your contribution.

@t8m t8m closed this Sep 1, 2023
openssl-machine pushed a commit that referenced this pull request Sep 1, 2023
@minima1cha0s @t8m
Removed unnecessary brace in ktls_configure_crypto
da57c0e 
CLA: trivial

Fixes #21498

Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21908)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@t-j-h t-j-h t-j-h approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: master Merge to master branch cla: trivial One of the commits is marked as 'CLA: trivial' severity: fips change The pull request changes FIPS provider sources severity: regression The issue/pr is a regression from previous released version tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

Bug in ssl/record/methods/ktls_meth.c - Missing brace in ktls_configure_crypto Function
5 participants
@minima1cha0s @slontis @t8m @t-j-h @openssl-machine