Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use armv8 .quad instead of .dword #21938

Closed
wants to merge 1 commit into from
Closed

Use armv8 .quad instead of .dword #21938

wants to merge 1 commit into from

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Sep 3, 2023

Fixes #18454.

@dg0yt
Copy link
Contributor Author

dg0yt commented Sep 3, 2023

Amends #17951.

@dg0yt
Copy link
Contributor Author

dg0yt commented Sep 3, 2023

FTR I couldn't run any tests. I hope it is covered by CI.

This was referenced Sep 3, 2023
Closed
Merged
@paulidale paulidale added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: bug The issue/pr is/fixes a bug tests: exempted The PR is exempt from requirements for testing labels Sep 3, 2023
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 4, 2023
@mattcaswell
Copy link
Member

This has only been labelled for master branch. Shouldn't we be backporting this to 3.1?

@dg0yt
Copy link
Contributor Author

dg0yt commented Sep 4, 2023

This has only been labelled for master branch. Shouldn't we be backporting this to 3.1?

Wrong label? This PR is for branch openssl-3.1. #21939 is for master.

@mattcaswell
Copy link
Member

Wrong label? This PR is for branch openssl-3.1. #21939 is for master.

Right. Actually that's how I noticed the incorrect label (the label says master but the PR targets 3.1).

Changing the label now. @paulidale, @t8m - please reconfirm

@mattcaswell mattcaswell added approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member branch: 3.1 Merge to openssl-3.1 and removed approval: done This pull request has the required number of approvals branch: master Merge to master branch labels Sep 4, 2023
@paulidale
Copy link
Contributor

+1

@t8m
Copy link
Member

t8m commented Sep 4, 2023

Yeah, OK for 3.1 of course.

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member labels Sep 4, 2023
@t8m
Copy link
Member

t8m commented Sep 5, 2023

Merged to 3.1 branch. Thank you for your contribution.

@t8m t8m closed this Sep 5, 2023
openssl-machine pushed a commit that referenced this pull request Sep 5, 2023
@dg0yt @t8m
Use armv8 .quad instead of .dword
b38f402 
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #21938)
@dg0yt dg0yt deleted the arm64-dword branch September 7, 2023 03:58
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Sep 23, 2023
@dg0yt
Use armv8 .quad instead of .dword
10d9516 
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from openssl/openssl#21938)

Signed-off-by: fly2x <fly2x@hitls.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: done This pull request has the required number of approvals branch: 3.1 Merge to openssl-3.1 tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dg0yt @mattcaswell @paulidale @t8m