04-test_encoder_decoder.t: Use algorithm that is non-fips also on 3.0.0 #21957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test encrypted RSA key with DES3 which is still allowed in the 3.0 fips provider. Instead use the traditional key format that uses MD5 to create the password based key. MD5 is disallowed in the 3.0 fips provider.
t8m
added
branch: master
|
Urgent as this is a CI failure fix. |
paulidale
approved these changes
Sep 4, 2023
paulidale
removed
the
approval: otc review pending
|
Okay with urgent. |
slontis
approved these changes
Sep 5, 2023
slontis
added
approval: done
|
Merged to the master branch. Thank you for the reviews. |
openssl-machine
pushed a commit
that referenced
this pull request
Sep 5, 2023
The test encrypted RSA key with DES3 which is still allowed in the 3.0 fips provider. Instead use the traditional key format that uses MD5 to create the password based key. MD5 is disallowed in the 3.0 fips provider. Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Shane Lontis <shane.lontis@oracle.com> (Merged from #21957)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test encrypted RSA key with DES3 which is still allowed in the 3.0 fips provider.
Instead use the traditional key format that uses MD5 to create the password based key. MD5 is disallowed in the 3.0 fips provider.
This should fix Provider compatibility CI:
https://github.com/openssl/openssl/actions/runs/6075083978/job/16480942800
Checklist