Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quicserver.c: Fix build with no-ssl-trace #21958

Closed
wants to merge 1 commit into from
Closed

quicserver.c: Fix build with no-ssl-trace #21958

wants to merge 1 commit into from

Conversation

t8m
Copy link
Member

@t8m t8m commented Sep 4, 2023

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer approval: otc review pending This pull request needs review by an OTC member triaged: bug The issue/pr is/fixes a bug severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing labels Sep 4, 2023
beldmit
beldmit approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if test passed, agree urgent

@beldmit beldmit removed the approval: otc review pending This pull request needs review by an OTC member label Sep 4, 2023
@paulidale paulidale added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: review pending This pull request needs review by a committer labels Sep 4, 2023
@paulidale
Copy link
Contributor

Merged to master as agree with urgent.

@paulidale paulidale closed this Sep 4, 2023
openssl-machine pushed a commit that referenced this pull request Sep 4, 2023
@t8m @paulidale
quicserver.c: Fix build with no-ssl-trace
b12c07c 
Reviewed-by: Tim Hudson <tjh@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #21958)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-j-h t-j-h t-j-h approved these changes

@beldmit beldmit beldmit approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch severity: urgent Fixes an urgent issue (exempt from 24h grace period) tests: exempted The PR is exempt from requirements for testing triaged: bug The issue/pr is/fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@t8m @paulidale @t-j-h @beldmit