-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OPENSSL_buf2hexstr() to use DEFAULT_SEPARATOR. #22041
Conversation
crypto/o_str.c
Outdated
* hex representation @@@ (Contents of buffer are always kept in ASCII, also | ||
* on EBCDIC machines) | ||
* hex representation with DEFAULT_SEPARATOR @@@ (Contents of buffer are always kept in ASCII, also | ||
* on EBCDIC machines) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't add end of line white space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would just remove this comment change. The function is documented sufficiently in the corresponding .pod file.
If you want to change it maybe use ````using the separator DEFAULT_SEPARATOR``` and then
fix up the lines to not be larger than 80 chars.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The end of line white space is removed.
The comment fall back, change 'len' to 'buflen' (<=80 chars).
Removed the merge commit.
Please remove the merge commits. We do not accept PRs with merge commits. |
You can collapse your commits using Use reword on the first commit and then squash the other 2 You could reword it to something like this..
Followed by a force push |
Please edit the commit message (again with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK with CLA: trivial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay with trivial
24 hours has passed since 'approval: done' was set, but this PR has failing CI tests. Once the tests pass it will get moved to 'approval: ready to merge' automatically, alternatively please review and set the label manually. |
Merged, thanks for the contribution. |
CLA: trivial Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from #22041)
CLA: trivial Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from openssl/openssl#22041) Signed-off-by: fly2x <fly2x@hitls.org>
let o_str.c OPENSSL_buf2hexstr follow DEFAULT_SEPARATOR, not static :
CLA: trivial