Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS zoo CI update #22130

Closed
wants to merge 7 commits into from
Closed

OS zoo CI update #22130

wants to merge 7 commits into from

Conversation

quarckster
Copy link
Member

@quarckster quarckster commented Sep 18, 2023 •
edited

At the moment CI is split between Github Actions and Buildbot. This PR is a part of the effort to migrate testing jobs to Github Actions. It adds a new linux job which should replace the corresponding ones from Buildbot:

  • 3.0:unix-centos8-x86_64
  • 3.0:unix-debian10-x86_64
  • 3.0:unix-debian11-x86_64
  • 3.0:unix-fedora38-x86_64
  • 3.0:unix-rockylinux8-x86_64
  • 3.0:unix-ubuntu2004-x86_64
  • 3.1:unix-centos8-x86_64
  • 3.1:unix-debian10-x86_64
  • 3.1:unix-debian11-x86_64
  • 3.1:unix-fedora38-x86_64
  • 3.1:unix-rockylinux8-x86_64
  • 3.1:unix-ubuntu2004-x86_64
  • master:unix-centos8-x86_64
  • master:unix-debian10-x86_64
  • master:unix-debian11-x86_64
  • master:unix-fedora38-x86_64
  • master:unix-rockylinux8-x86_64
  • master:unix-ubuntu2004-x86_64

Related to openssl/project#216
Successful run in my fork https://github.com/quarckster/openssl/actions/runs/6219139556

@quarckster
os zoo ci
b494b9f 
Use a Github Actions expression to set value for the environment
variable.
@quarckster
os zoo ci
a7634c7 
Migrate some Linux Buildbot jobs to Github Actions. See
openssl/project#216.
@quarckster
os zoo ci
034a05a 
Create a separate MacOS job. 'matrix.zoo.cc' is not set for this job so
it should be removed.
@quarckster
os zoo ci: reformat windows job
72417a2
@quarckster
os zoo ci: update copyright year
fd6ddf5
@quarckster
os zoo ci: add 3.0 and 3.1 branches
219ec20
paulidale
paulidale approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@paulidale paulidale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement.

@paulidale
Copy link
Contributor

Should the 3.0 and 3.1 variations be part of those branches rather than here?

@quarckster
Copy link
Member Author

quarckster commented Sep 18, 2023 •
edited

Should the 3.0 and 3.1 variations be part of those branches rather than here?

I thought about that. In the case of scheduled jobs, it makes less sense. CI won't test the changes that will be done in the scheduled jobs. Moreover, when we deprecate a branch we should disable scheduled jobs for it as well by submitting a PR to that branch. It is ok but in my opinion, we can just forget about it. Anyway, I don't have a strong opinion about that I'd like to hear other thoughts.

@t8m t8m added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: feature The issue/pr requests/adds a feature tests: exempted The PR is exempt from requirements for testing labels Sep 18, 2023
@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Sep 18, 2023
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Sep 19, 2023
@openssl-machine
Copy link
Collaborator

This pull request is ready to merge

@paulidale
Copy link
Contributor

Merged, thanks.

@paulidale paulidale closed this Sep 19, 2023
openssl-machine pushed a commit that referenced this pull request Sep 19, 2023
@quarckster @paulidale
os zoo ci
e900942 
Use a Github Actions expression to set value for the environment
variable.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from #22130)
@quarckster quarckster deleted the os-zoo-containers branch September 20, 2023 07:43
wanghao75 pushed a commit to openeuler-mirror/openssl that referenced this pull request Sep 23, 2023
@quarckster
os zoo ci
6582c34 
Use a Github Actions expression to set value for the environment
variable.

Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
(Merged from openssl/openssl#22130)

Signed-off-by: fly2x <fly2x@hitls.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t8m t8m t8m approved these changes

@paulidale paulidale paulidale approved these changes

Assignees
No one assigned
Labels
approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Merge to master branch tests: exempted The PR is exempt from requirements for testing triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@quarckster @paulidale @openssl-machine @t8m