Add include of e_os2.h in quictestlib.c to allow symbol definition consistency. #22179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsbeckerca
force-pushed
the
fix-22178
branch
2 times, most recently
from
293c9c5
to
587798f
Compare
github-actions
bot
added
the
severity: fips change
rsbeckerca
changed the title
|
I have made this change NonStop-specific but I think it might apply to any c99 builds because the unspecified type, |
|
This passed build/test on our platform. |
paulidale
approved these changes
Sep 24, 2023
paulidale
added
branch: master
beldmit
added
approval: done
mattcaswell
requested changes
Sep 25, 2023
There was a problem hiding this comment.
We have plenty of code already that uses struct timeval which, as far as I know has compiled just fine on NonStop. I don't think this is the correct fix. I have an alternative suggestion in #22183.
mattcaswell
added
approval: review pending
Fixes: openssl#22178 Signed-of-by: Randall S. Becker <randall.becker@nexbridge.ca>
rsbeckerca
force-pushed
the
fix-22178
branch
from
587798f
to
71c7128
Compare
rsbeckerca
changed the title
github-actions
bot
removed
the
severity: fips change
rsbeckerca
changed the title
|
I originally called this "Move" instead of "Add" because it was in comparison to the proposed change by @mattcaswell. This just moves where the |
|
FYI: This change, commit 71c7128, did pass build/test on NonStop with c99. |
paulidale
approved these changes
Sep 26, 2023
mattcaswell
approved these changes
Sep 26, 2023
|
This updated version looks much better. |
t8m
approved these changes
Sep 26, 2023
t8m
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
Pushed. |
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Oct 9, 2023
Fixes: #22178 Signed-of-by: Randall S. Becker <randall.becker@nexbridge.ca> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from openssl/openssl#22179) Signed-off-by: fly2x <fly2x@hitls.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #22178
Signed-of-by: Randall S. Becker randall.becker@nexbridge.ca