remove files under test directory from coverage report #22212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcaswell
reviewed
Sep 28, 2023
|
We should probably filter out the "fuzz" test files too |
quarckster
force-pushed
the
coveralls
branch
from
e1a1999
to
2bcc4f0
Compare
mattcaswell
approved these changes
Sep 28, 2023
quarckster
force-pushed
the
coveralls
branch
from
2bcc4f0
to
bf7d9e9
Compare
|
@mattcaswell I forgot to checkout submodules locally and there should be more paths to exclude. I pushed a new commit. I excluded |
levitte
reviewed
Sep 28, 2023
mattcaswell
approved these changes
Sep 28, 2023
levitte
approved these changes
Sep 28, 2023
paulidale
approved these changes
Sep 29, 2023
paulidale
added
approval: done
|
Heh, this will clearly worsen our total coverage number. 😁 |
t8m
approved these changes
Sep 29, 2023
|
24 hours has passed since 'approval: done' was set, but as this PR has been updated in that time the label 'approval: ready to merge' is not being automatically set. Please review the updates and set the label manually. |
|
Merged to the master branch. Thank you. |
openssl-machine
pushed a commit
that referenced
this pull request
Oct 2, 2023
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #22212)
wanghao75
pushed a commit
to openeuler-mirror/openssl
that referenced
this pull request
Oct 9, 2023
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Richard Levitte <levitte@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl/openssl#22212) Signed-off-by: fly2x <fly2x@hitls.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.